From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10FDE3254A5 for ; Tue, 9 Jun 2026 05:38:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780983486; cv=none; b=HxVx4cWkBmhTPgfbpcprdKm/pZNb6+BbpekUZ2PmjFQox0GAY28W/DCNRFyxQLoez5MP0+IafROnehybJ7P8D4DUIeYJrH2N9AeEumGrTuPciZmm8QRuGTn6sLGYJCr4Yt+D1hIy8aBshft+M3hE7FUlXbx0IWTwrAVn5JyE1TU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780983486; c=relaxed/simple; bh=13H4rBXOwb8xQGBX0guI7OEhjmT0Lz/E1TcGCfJ+rwM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P20Jwqy7T8G1yJbmzmlqDfT2NFYCIaBoWp7rmqHRxl558ysvOX9eJxNndr+NDLfxxK19QyeVGVRXCKDsAcojNM7dpUqzIAbuTcgVOJZ1W1gjvuzfAvpRcNewkUaQNMTyEqScNUSURjNXRL3b7pl8CFZl9rroG7kXgwgwSz5Bd/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h4sVGkdP; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h4sVGkdP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780983485; x=1812519485; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=13H4rBXOwb8xQGBX0guI7OEhjmT0Lz/E1TcGCfJ+rwM=; b=h4sVGkdPQ/pxf8LD4NzFNdYxrD2NLaA/XuCDMu4Qav2ob1AKo3eyLGvh b3qKoU7lS6cU7jWCIDRDvcEQmE9wGvsI6hCQZ2DA1fZ/mBMCPdQ/l5aQZ KKGOggrniQ9kkBFHLQptdhunovWsAA7HnMrBUwrp+97m8umlDimhhKisD FhqVWZ8zRIMRwZOdKH2TWRTzZpsjkMVelDql2uaCZMobost0uJA1lIuDN 6lf7xWM/G/QCC87/n+XZB8GKgQ3igismFV1Rg9fK2QurhPMQEBRb9TGd5 CFKrFKZqH6lRRoAvoJ7GurAlw08jLFqpen5dfpL9ccgpImecCasLPkBQ2 Q==; X-CSE-ConnectionGUID: a6ZsSGPNR02rXAecdsiOSw== X-CSE-MsgGUID: T8zmvEIxTXaSy6jt21df0w== X-IronPort-AV: E=McAfee;i="6800,10657,11811"; a="104398003" X-IronPort-AV: E=Sophos;i="6.24,195,1774335600"; d="scan'208";a="104398003" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 22:38:05 -0700 X-CSE-ConnectionGUID: 3LkUyPELRx6Cy7oCkd0/LQ== X-CSE-MsgGUID: fJrLrpFLTNifHob7ADMrZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,195,1774335600"; d="scan'208";a="244914220" Received: from unknown (HELO [10.238.2.24]) ([10.238.2.24]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 22:37:57 -0700 Message-ID: Date: Tue, 9 Jun 2026 13:37:54 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 16/22] KVM: selftests: Load per-vCPU guest stack in TDX boot parameters To: Lisa Wang Cc: Andrew Jones , Ackerley Tng , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Oliver Upton , Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260521-tdx-selftests-v13-v13-0-6983ae4c3a4d@google.com> <20260521-tdx-selftests-v13-v13-16-6983ae4c3a4d@google.com> Content-Language: en-US From: Binbin Wu In-Reply-To: <20260521-tdx-selftests-v13-v13-16-6983ae4c3a4d@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/2026 7:16 AM, Lisa Wang wrote: > From: Sagi Shahar > > Allocate a guest stack for each vCPU and record the GVA in the TDX boot > parameters region to allow proper vCPU initialization. > > Co-developed-by: Ackerley Tng > Signed-off-by: Ackerley Tng > Signed-off-by: Sagi Shahar > Signed-off-by: Lisa Wang Reviewed-by: Binbin Wu One nit below. [...]> > +void tdx_vcpu_load_boot_parameters(struct kvm_vm *vm, struct kvm_vcpu *vcpu) > +{ > + struct td_boot_parameters *params = > + addr_gpa2hva(vm, TD_BOOT_PARAMETERS_GPA); > + struct td_per_vcpu_parameters *vcpu_params = > + ¶ms->per_vcpu[vcpu->id]; > + > + vcpu_params->esp_gva = kvm_allocate_vcpu_stack(vm); > +} > + > + An extra empty line. > static struct kvm_tdx_capabilities *tdx_read_capabilities(struct kvm_vm *vm) > { > struct kvm_tdx_capabilities *tdx_cap = NULL; >