Re: [PATCH v2 7/8] PCI/TSM: Add pci_tsm_guest_req() for managing TDIs

[Xu Yilun <yilun.xu@linux.intel.com>]

On Wed, Nov 12, 2025 at 06:14:45PM -0800, Dan Williams wrote:
> A PCIe device function interface assigned to a TVM is a TEE Device
> Interface (TDI). A TDI instantiated by pci_tsm_bind() needs additional
> steps taken by the TVM to be accepted into the TVM's Trusted Compute
> Boundary (TCB) and transitioned to the RUN state.
> 
> pci_tsm_guest_req() is a channel for the guest to request TDISP collateral,
> like Device Interface Reports, and effect TDISP state changes, like
> LOCKED->RUN transititions. Similar to IDE establishment and pci_tsm_bind(),
              ^
transition

[...]

> +ssize_t pci_tsm_guest_req(struct pci_dev *pdev, enum pci_tsm_req_scope scope,
> +			  sockptr_t req_in, size_t in_len, sockptr_t req_out,
> +			  size_t out_len, u64 *tsm_code)
> +{
> +	struct pci_tsm_pf0 *tsm_pf0;
> +	struct pci_tdi *tdi;
> +	int rc;
> +
> +	/* Forbid requests that are not directly related to TDISP operations */
> +	if (scope > PCI_TSM_REQ_STATE_CHANGE)
> +		return -EINVAL;

So we are not ready for PCI_TSM_REQ_DEBUG_READ/WRITE, is it?

Others look good to me.

Reviewed-by: Xu Yilun <yilun.xu@linux.intel.com>