From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF04944F for ; Mon, 2 Feb 2026 07:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770017426; cv=none; b=TFlGU70ECZQrKEgQMs3EQaq9jReEpASUiu3METdQW05rdJ+ofctJn/z3SM7UnMKwtfZKEpL9Q27d19hTOfL5YZ37VJyj/SIZK2/ylYRb0eCgUUVeYiFierU7ML6b0PZ5/j89p0mlfa57MNCSFaAgd2R6R/DKgmbo3p+nYZOJ4+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770017426; c=relaxed/simple; bh=7BCjcgwThACpqKINVEDrGd72svHvdvaoqjhRgec9HSQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MEDmMxPLzDGP6qtySG6c+Lw3FzOKoE1c0PrFaBYf01pAn9N+qE1wxDEpPlPXNsEktWPObE3jcEpLi+t6nQKAxcSDM7iouTt2yUL0W33rYg6S4nqIrtYA0Oat25/+KUu5LU/ERyft1WpzxVdkssAKVInxbD2lSeKlryB5x07I0JA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=P7wSDfi2; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="P7wSDfi2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770017424; x=1801553424; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7BCjcgwThACpqKINVEDrGd72svHvdvaoqjhRgec9HSQ=; b=P7wSDfi2py80Sa64Rt6oYYXGJAYYoHOdmlbii5Byjkf31xt7NcACG3zW A75KiY5vV0Il+yBRc5prO24R5BoQ0yfe3pjvR2V2EcyJ8GfHL23MJR/dc LKYiu4UIk5FxXzni2yxF/wrr7Ww81YBdMFDI18OiqDXQ2yKrYqJIslDfT VsR34xMtdZSf5s28C3VbaPrp0ve16kWpP9ZSglxEiV0R/ANXdWgZzxPlp Cie8nzvI/ksBDWp5FtoShP+BWYS/mwB4jpVXpAKtmxLimaO+fU5Zq0PR+ Oi613fNuRK5OKF8Z3kLC44VBm+HcAbJcN9j9110djxJA7iRFYGTt+abK8 g==; X-CSE-ConnectionGUID: aR2nUMCPRRu3UYYOH0rlMg== X-CSE-MsgGUID: ak+wCa2vREavjq8ppwMcCA== X-IronPort-AV: E=McAfee;i="6800,10657,11689"; a="70188880" X-IronPort-AV: E=Sophos;i="6.21,268,1763452800"; d="scan'208";a="70188880" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2026 23:30:23 -0800 X-CSE-ConnectionGUID: Uw5Z8H+rSOmQG1IMkRDQ4w== X-CSE-MsgGUID: dAuO3KFYSnadE7L3YUfpwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,268,1763452800"; d="scan'208";a="209624610" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmviesa008.fm.intel.com with ESMTP; 01 Feb 2026 23:30:17 -0800 Date: Mon, 2 Feb 2026 15:11:53 +0800 From: Xu Yilun To: Chao Gao Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, reinette.chatre@intel.com, ira.weiny@intel.com, kai.huang@intel.com, dan.j.williams@intel.com, sagis@google.com, vannapurve@google.com, paulmck@kernel.org, nik.borisov@suse.com, zhenzhong.duan@intel.com, seanjc@google.com, rick.p.edgecombe@intel.com, kas@kernel.org, dave.hansen@linux.intel.com, vishal.l.verma@intel.com, Farrah Chen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH v3 18/26] x86/virt/seamldr: Log TDX Module update failures Message-ID: References: <20260123145645.90444-1-chao.gao@intel.com> <20260123145645.90444-19-chao.gao@intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123145645.90444-19-chao.gao@intel.com> > +static void print_update_failure_message(void) > +{ > + static atomic_t printed = ATOMIC_INIT(0); > + > + if (atomic_inc_return(&printed) == 1) > + pr_err("update failed, SEAMCALLs will report failure until TDs killed\n"); > +} Not sure why it can't be just pr_err_once()? > + > /* > * See multi_cpu_stop() from where this multi-cpu state-machine was > * adopted, and the rationale for touch_nmi_watchdog() > @@ -289,10 +297,13 @@ static int do_seamldr_install_module(void *params) > break; > } > > - if (ret) > + if (ret) { > atomic_inc(&tdp_data.failed); > - else > + if (curstate > TDP_SHUTDOWN) > + print_update_failure_message(); > + } else { > ack_state(); > + } > } else { > touch_nmi_watchdog(); > rcu_momentary_eqs(); > -- > 2.47.3 >