Re: [PATCH v2 08/19] PCI/TSM: Add "evidence" support

[Xu Yilun <yilun.xu@linux.intel.com>]

> +void pci_tsm_init_evidence(struct pci_tsm_evidence *evidence, int slot,
> +			   enum hash_algo digest_algo)
> +{
> +	evidence->slot = slot;
> +	evidence->generation = 1;
> +	evidence->digest_algo = digest_algo;
> +	init_rwsem(&evidence->lock);

IIUC, this function is for link tsm driver, is it? But in the following
patch, devsec tsm would consume pci_tsm_mmio_alloc() which uses
evidence->lock. So my solution is to initialize the lock on tsm
construction.

--------8<--------
diff --git a/drivers/pci/tsm/core.c b/drivers/pci/tsm/core.c
index 9f062218c312..c55deeafe32b 100644
--- a/drivers/pci/tsm/core.c
+++ b/drivers/pci/tsm/core.c
@@ -1175,7 +1175,6 @@ void pci_tsm_init_evidence(struct pci_tsm_evidence *evidence, int slot,
        evidence->slot = slot;
        evidence->generation = 1;
        evidence->digest_algo = digest_algo;
-       init_rwsem(&evidence->lock);
 }
 EXPORT_SYMBOL_GPL(pci_tsm_init_evidence);

@@ -1198,6 +1197,7 @@ int pci_tsm_link_constructor(struct pci_dev *pdev, struct pci_tsm *tsm,
        }
        tsm->pdev = pdev;
        tsm->tsm_dev = tsm_dev;
+       init_rwsem(&tsm->evidence.lock);

        return 0;
 }
@@ -1221,6 +1221,7 @@ int pci_tsm_devsec_constructor(struct pci_dev *pdev, struct pci_tsm_devsec *tsm,
        pci_tsm->tdi = NULL;
        pci_tsm->pdev = pdev;
        pci_tsm->tsm_dev = tsm_dev;
+       init_rwsem(&pci_tsm->evidence.lock);

        return 0;
 }