From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F07367F40 for ; Fri, 13 Mar 2026 10:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398796; cv=none; b=D7QPWM7BxnLrmc2LFqnouZmWIl4GHxMD8rhaxWFcI/3AzYWT2L4zAlOQyhaSDQl+4pe9ewYgbxZZdsi0mVNrDIWFkKayRLWAOWliWxmPfCNbHXr13zJ544qwFYC9GgWA6bXVkaA4XDU5Jzms1xFwqZx9jkqf4TmHZYGmLQM5TaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398796; c=relaxed/simple; bh=PTmY2nKD6hoY/LGYYNm8rJAUyVDhur4/C7CTrQQPHqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HI18Kv76IzXokuuRA5l6VojRBlNwrRaSVMIqIgbMHmOqWXnwc2fpGHCrHqqMrlp+a7aJBFwEsfCf46fygGO6BCTYapHZU2hDIzIIWUzHQpTRQma1FnRgAuktOglHwT2y77VBLvTJ4vVNOUILTA/Sba/m20b6fglklJqcI0KxCY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fZge6TEc; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fZge6TEc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773398795; x=1804934795; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PTmY2nKD6hoY/LGYYNm8rJAUyVDhur4/C7CTrQQPHqU=; b=fZge6TEc2HVgc9YXVZPkJw55GL5EELLWTuq8WgJJlkWFQSDXux/gG3C+ lyKCWwnudSvddpETPmd0zGoPkBdEkGV4YqSxSqcSqp4ai4ODvBbW5wfpv LZJkcS1zMgyzpJ4RADd8NOeJSwGgfxndQGsefo8wNvWva1UG1bchcK/Ge nXPiLXSolzOMZalt3pK2w0G6hDG0XzzHKOj0nSZfhulITdn7IJszmWeEk gdXBd5GUr+cHhg0wpkiE+oEj8Dl+Z9dPzDx2CQYaLvVEXudP18c0N9ajh tE5F0Fs1fgFAVJfqwbgHzkyI6hOCvfkTHk3Zki/1GrZM884Fwnq4iQfL3 A==; X-CSE-ConnectionGUID: I2peHxJ+TEiGDroLAvZaDw== X-CSE-MsgGUID: G6EvSMCJSGOp7uZP4v86Pw== X-IronPort-AV: E=McAfee;i="6800,10657,11727"; a="74692811" X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="74692811" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 03:46:35 -0700 X-CSE-ConnectionGUID: Ko8UEkYQR9+8HbK6k84lPA== X-CSE-MsgGUID: qY5hGhJWRMe74quojS+aTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="221077974" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orviesa009.jf.intel.com with ESMTP; 13 Mar 2026 03:46:31 -0700 Date: Fri, 13 Mar 2026 18:26:14 +0800 From: Xu Yilun To: "Aneesh Kumar K.V" Cc: Dan Williams , linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, gregkh@linuxfoundation.org, aik@amd.com, bhelgaas@google.com, alistair23@gmail.com, lukas@wunner.de, jgg@nvidia.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marek Szyprowski , Robin Murphy Subject: Re: [PATCH v2 10/19] x86, swiotlb: Teach swiotlb to skip "accepted" devices Message-ID: References: <20260303000207.1836586-1-dan.j.williams@intel.com> <20260303000207.1836586-11-dan.j.williams@intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > > @@ -365,6 +365,7 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > > > > io_tlb_default_mem.force_bounce = > > swiotlb_force_bounce || (flags & SWIOTLB_FORCE); > > + io_tlb_default_mem.bounce_unaccepted = flags & SWIOTLB_UNACCEPTED; > > > > This should be. > > @@ -373,7 +373,7 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > > io_tlb_default_mem.force_bounce = > swiotlb_force_bounce || (flags & SWIOTLB_FORCE); > - io_tlb_default_mem.bounce_unaccepted = flags & SWIOTLB_UNACCEPTED; > + io_tlb_default_mem.bounce_unaccepted = !!(flags & SWIOTLB_UNACCEPTED); Ah yes, I just realized assigning to a 1-bit field would truncate the assigned value to its LSB...