From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C8113EFFD0 for ; Wed, 27 May 2026 10:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779879389; cv=none; b=li8DquirUyTC62f97D1a0RqK6Cbb3UbkF9oOS0PawGdaJ2DhA427+pg88+qdpG1/dtQJMgHZD7+j7i01mWryCRZsijnWRIiF3xelfIYvq2ENjLVlcO0f3H8ad3G1wKIi3qRvOSMp5i+xZoy8owYc9rQz0nxLHKql+UxeZNf26So= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779879389; c=relaxed/simple; bh=rNUmpZLe1fbwIvKXE+to8JaQxK8DTUurXcsabTl7BFA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OG0JFTTH2TDCyA60YhWwWoWOLZDmAI3eU13iLQaKhtQsWqyy/eR9lvDR30CFly8ogsXx5XaipEEg6AesZ8ZGcj7rl7PDl7eNXFUMxwzPRFH6Fb31TcQq7PCveCF/gtYc+1546HPdq0VdbZvYKO27oeUpTfehgcnTWrSCqR84mhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n5Xvc4gv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n5Xvc4gv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE9741F00A3C; Wed, 27 May 2026 10:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779879387; bh=5n7mSfHGX4F9t6WFOipELPIaR8w8e1jVF9EKHmy/yUE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=n5Xvc4gv8yShfiPpCU2dDxRwTgag+yIwrvXY8AWOnopExhdn2fkZ3XAYdXfQQu+L/ JkOcb5Afw1in1R4H901TI78dXj46HGrilneUpOHHxgatePKVhLqWwbjCbbEVKY4HNv L8Il3WyXVU8eiTSQ4YzSHwjlzSN7WmeIAta+z8XQrKKOs2Kv87qoRKC5/v5EhSh20f NecXJl0EDhYWXrxxZgUgHKfYY9q+gUF3zBSASAh+jga/ZZAAIsOsKTphCj1oQef+3T vXcVHqlg2xx9feiOVTE07rbc9oLpvful9IrwloIQBl/pJCIDpq51ehhwTNzZY7vAis HpVaKuoSy0FyQ== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 44C97F4007E; Wed, 27 May 2026 06:56:26 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Wed, 27 May 2026 06:56:26 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFXA2uWKoyT6YuTKua2PHcWTP+H8rYOTTZC7SKk+/8FqKG5UzIFAWbnYVusP9hZi2 BhsBP+F/nACgys+U/v4S/1wCXD6SBbofLCIX6j/pcPC6vgN8rt495hiyh68/UlWrI9IQTQ pyD8fuwUF+xRJlXU07eUNU1h19KMjNpIUDhSNVBgmIeijZDfbu3QmxTi4vrB9U9QlWGdfY p2b9nGLSST/JJ+wFEQiQexL3loY48QgkfIr1e1khw0rl1laJu3ExZuVSXmcadfbMplAv36 XIEPyx23TPPg5xwSxEeOW5bKM3f1kjgpk8TYjFrIKrgFg1PuzLUzjRir3m5+uRGzhT1cG6 Fql1KyhNpIoeubO4Ki9v1U1KbFwVug1p/TJiU4Cha+GdM5nmL9+OlQP7KgOvGizr5tf5MQ hH2W1eBMZdhXS7xYL+Gyzsgrxix10lK9f5OZkCjoUHxgw1ln4zcYEXNscVh3ffJQFAKXWh 3UWWVuh8FN5LaZ1TVgYI9xjmgV7ICUkmqzeReh2Bg1blWNOPrSXoa0QTOJbVcf1nf+4XwN E/lCog4HdNNIPSy3tJNz/Pu8dlKVapbCjHOE2LO6/XqqU7RMnXcv4zJdSNSi7FclN3KFvT 0VXi6BvKS5QAa8CysVVlmXQ8GaFzYysFgpNPRisQDidwlsgAA8lZdx3yEgcA X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 May 2026 06:56:24 -0400 (EDT) Date: Wed, 27 May 2026 11:56:20 +0100 From: Kiryl Shutsemau To: Chao Gao , rick.p.edgecombe@intel.com Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, binbin.wu@linux.intel.com, dave.hansen@linux.intel.com, djbw@kernel.org, ira.weiny@intel.com, kai.huang@intel.com, nik.borisov@suse.com, paulmck@kernel.org, pbonzini@redhat.com, reinette.chatre@intel.com, sagis@google.com, seanjc@google.com, tony.lindgren@linux.intel.com, vannapurve@google.com, vishal.l.verma@intel.com, yilun.xu@linux.intel.com, xiaoyao.li@intel.com, yan.y.zhao@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v10 04/25] x86/virt/tdx: Move TDX_FEATURES0 bits to asm/tdx.h Message-ID: References: <20260520133909.409394-1-chao.gao@intel.com> <20260520133909.409394-5-chao.gao@intel.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520133909.409394-5-chao.gao@intel.com> On Wed, May 20, 2026 at 06:38:07AM -0700, Chao Gao wrote: > Future changes will add support for new TDX features exposed as > TDX_FEATURES0 bits. The presence of these features will need to be checked > outside of arch/x86/virt. So the feature query helpers, and the > TDX_FEATURES0 defines they reference, will need to live in the widely > accessible asm/tdx.h header. Move the existing TDX_FEATURES0 to asm/tdx.h > so that they can all be kept together. > > Opportunistically switch to BIT_ULL() since TDX_FEATURES0 is 64-bit. > > No functional change intended. I don't have a problem with the patch, but it seems to be colliding with DPAMT patchset that also moves the define around. Rick, I assume this patchset going upstream first, right? -- Kiryl Shutsemau / Kirill A. Shutemov