From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0A532836E for ; Tue, 16 Jun 2026 00:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781568287; cv=none; b=Yh1Q9DbUClxj+7eQeiJWhwKL9SyeKOGRN1c0lS5MleoGsZXq8JjA+qHvGFyLC3JQcLkXHrLir6UduTJrtpgnTgKHUhJ8ezQA/TrmDWa5VAvthZNvHfrC5mKnEYoqSj7H9FrCzgAKGMDuvkEsSNES4YLMVBiADlQUyq4GOfiBOTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781568287; c=relaxed/simple; bh=ScZO0zTAhAUUrCPn2ItLGHBxZgasFBIGvOq7yrsaQ1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kiQNpPvVcoG+fn9Nwygpd67gn/P53ZrRLtCj6mFwTrfj/r7brw1NyE8RpkjQmjfNGEsrEEZBAeiMHY0AkUKWVZTxAlGk2zIUEAduDQO/i4+1FrSzAcU/FLXznH0PinrAYbVvanHZauxnsGQOL95jY6XYhSMqE2nvf2J4gmRzdN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SPfWZjuf; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SPfWZjuf" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c67ea316caso11815ad.1 for ; Mon, 15 Jun 2026 17:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781568285; x=1782173085; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GHN6z9ynbO2Res19U2YVQS85Id9OG0/5Hx4RzpTAx3U=; b=SPfWZjuftv/2tuovs+H9nLjDZEOQt5CbDl0/uq0by9yS4ayvHA7xq2m/JjtGe/SkTB FCn/4jWj3iJJbIbdVvN3+T+ULCqAeZz1KjuRGg0lxbrLo/PIEkyZ6nyBOo2mPrLxC4rT uA7HBpPdJeo2TAa81pWyxrkV+TYJ7K3bsxDXMC02y5PWvc/Gs+2mmxuKmC9xxu/SKIGg e5yHduM+dXBllkJYk4iPsXEq2wgYYQc0a0J6DIyD4aT3PUzcbJusI12zxbTkXv962EEF WIldksT5H77PLAqrmTyrQmzSzypgjS0SW1UpOFNjwfKLI9yKX9vt2usFjj7l8BXjhsiY xwFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781568285; x=1782173085; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GHN6z9ynbO2Res19U2YVQS85Id9OG0/5Hx4RzpTAx3U=; b=TReTt7gDLfoC2LIUFbijpE22/eqIPHdr6kbDxdMNpdaab8jEkeY5Ji6j3O86z5QniQ m1NugBB72kKbFKbAm3xmCmSWzUgnzO46hlbGOG8M7li/cbtnId8QOCxj2r66ex6ElJC2 mqzp/2BwJxmJdE1OuYX8wN/kjIPeg2JCdbnIF+nmWbTwrz4iiRcjZX0Upr50VWkCIzW0 ey2X1skmmRGJkM6i9C7iupJ9S081JGAuXwebuNz1lxyX+q3lrkfvmOyaxksD9B2xD0ll UA2O0qAPBGrwTm3U+MwcJGizp6DqGVvV7hTLmjgbMoVdybhBvHNLnpMtDWJBLmvyArL/ bB2A== X-Forwarded-Encrypted: i=1; AFNElJ/lMx9h5lpHuPeSWpUXg3uRNEqKHhg9WhPurPcRlf0hcR8odwfTP2N+rcFkrorktf3ZvVQBKT+eNR+A@lists.linux.dev X-Gm-Message-State: AOJu0YyswUmJMXirXiAdFlfavkcgRbIQWdVcpaHZpu4ehY5T05R+V8nx V2m+P2nRC3P9IDhb8mpSKFUoRTBWCBb3EQ/Cn4Heq6wYfWZOL8J/H0qAZ0LpHV8DRQ== X-Gm-Gg: Acq92OH/23FdDB8NMFN6EkaHTa/7Q3Hx5yRxeDNXJmGOzkDK+JYAmeHc7x9GYwovooZ QONtCEJQaeCiLuCvjpCl1kneDw2wbz6USOVWCsccL17nEoIJk9X1LsUMSL3/D8Zx3Jqm/GNakU4 NFRN84hYmYRQqq16E/g9lCsPtXM8fte/O42cm/HESkShOBush8WkdXJe5YKKQnywTgleGq9fpY8 PyK8Dhoj3jzL5CDIGtUT4YHrcXIbW20UkMQT9Ik7p3WFIOhn7GWk+HGJkntgJzmlDVA2DOMDRl2 cBJBv1r+Uriu6+JLGmpaZnkkMJMz6w3eV+gU4vqbfFD7rq2PBMzwxdOmsc7OvEb/2bK8ZGbD+m2 3a4r5IC8FJS9pYJURMCoWqf+PTVVqu0sDJAFf4i72eb2u8Tu2WdngjwfkiCc1c1giUmCXvVJnSK MhOF28yw6YyZzhEZUW0jvDHzfFwGtLPlgkRJ0fdr+lEe+W5rnQOVOB2jojagYFyexwm5k= X-Received: by 2002:a17:903:2a84:b0:2bd:3bfd:74f1 with SMTP id d9443c01a7336-2c69a26dea6mr1202495ad.2.1781568284918; Mon, 15 Jun 2026 17:04:44 -0700 (PDT) Received: from google.com (230.0.127.34.bc.googleusercontent.com. [34.127.0.230]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434b03fd0bsm11119220b3a.50.2026.06.15.17.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 17:04:44 -0700 (PDT) Date: Tue, 16 Jun 2026 00:04:40 +0000 From: Lisa Wang To: Binbin Wu Cc: Andrew Jones , Ackerley Tng , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Oliver Upton , Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v13 13/22] KVM: selftests: Set first memory region as shared if guest_memfd Message-ID: References: <20260521-tdx-selftests-v13-v13-0-6983ae4c3a4d@google.com> <20260521-tdx-selftests-v13-v13-13-6983ae4c3a4d@google.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 08, 2026 at 04:03:23PM +0800, Binbin Wu wrote: > On 5/22/2026 7:16 AM, Lisa Wang wrote: > > + * exactly like other memory providers. > > */ > > - flags = 0; > > - if (is_guest_memfd_required(shape)) > > + if (is_guest_memfd_required(shape)) { > > flags |= KVM_MEM_GUEST_MEMFD; > > + gmem_flags |= GUEST_MEMFD_FLAG_INIT_SHARED; > > + } > > > > - vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, 0, 0, nr_pages, flags); > > + vm_mem_add(vm, VM_MEM_SRC_ANONYMOUS, 0, 0, nr_pages, flags, -1, 0, gmem_flags); > > The build failed due to this: > > lib/kvm_util.c: In function ‘__vm_create’: > lib/kvm_util.c:507:9: error: too many arguments to function ‘vm_mem_add’ > 507 | vm_mem_add(vm, VM_MEM_SRC_ANONYMOUS, 0, 0, nr_pages, flags, -1, 0, gmem_flags); > | ^~~~~~~~~~ > In file included from lib/kvm_util.c:9: > include/kvm_util.h:714:6: note: declared here > 714 | void vm_mem_add(struct kvm_vm *vm, enum vm_mem_backing_src_type src_type, > | ^~~~~~~~~~ > lib/kvm_util.c: At top level: > cc1: note: unrecognized command-line option ‘-Wno-gnu-variable-sized-type-not-at-end’ may have been intended to silence earlier diagnostics > > It seems the patch set doesn't wire gmem_flags parameter to vm_mem_add(). This series need to based on "KVM: selftests: Add support for mmap() on guest_memfd in core library" for the gmem_flags parameter. Lisa > > for (i = 0; i < NR_MEM_REGIONS; i++) > > vm->memslots[i] = 0; > > > > >