From: Tony Lindgren <tony.lindgren@linux.intel.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: x86@kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, kas@kernel.org,
rick.p.edgecombe@intel.com, yilun.xu@intel.com,
xiaoyao.li@intel.com, sohil.mehta@intel.com,
adrian.hunter@intel.com, kishen.maloor@intel.com,
peter.fang@intel.com, baolu.lu@linux.intel.com,
zhenzhong.duan@intel.com, chao.gao@intel.com,
artem.bityutskiy@linux.intel.com, kvm@vger.kernel.org
Subject: Re: [PATCH 6/6] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update
Date: Tue, 25 Aug 2026 11:35:55 +0300 [thread overview]
Message-ID: <ao1T61FjnTQwa6qN@tlindgre-MOBL1> (raw)
In-Reply-To: <20260821032920.256225-7-yilun.xu@linux.intel.com>
On Fri, Aug 21, 2026 at 11:29:20AM +0800, Xu Yilun wrote:
> --- a/arch/x86/virt/vmx/tdx/tdx.c
> +++ b/arch/x86/virt/vmx/tdx/tdx.c
> @@ -1289,7 +1289,7 @@ static __init int tdx_ext_mem_setup(void)
> return ret;
> }
>
> -static __init int tdx_ext_init(void)
> +static int tdx_ext_init(void)
> {
> struct tdx_module_args args = {};
> u64 ret;
> @@ -1332,6 +1332,19 @@ static __init int init_tdx_module_extensions(void)
> return tdx_ext_init();
> }
>
> +/*
> + * Don't update the extensions metadata, just follow the requirement originated
> + * during TDX module initialization. Let the extensions re-initialization fail
> + * if more memory is needed, or if ext_required is dropped after updates.
> + */
> +static int update_tdx_module_extensions(void)
> +{
> + if (!tdx_sysinfo.ext.ext_required)
> + return 0;
> +
> + return tdx_ext_init();
> +}
> +
> static __init int init_tdx_module(void)
> {
> int ret;
> @@ -1532,6 +1545,10 @@ int tdx_module_run_update(void)
> */
> WARN_ON_ONCE(ret);
>
> + ret = update_tdx_module_extensions();
> + if (ret)
> + return ret;
> +
> tdx_module_state.initialized = true;
> return 0;
> }
How about use naming to follow the comments and patch $subject, maybe
use reinit_tdx_module_extensions() naming instead?
But now I'm wondering how come we need separate functions for init and
reinit of the extensions, would a bool flag for init be enough to signal
the reinit?
prev parent reply other threads:[~2026-08-25 8:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 3:29 [PATCH 0/6] Enable TDX module extensions Xu Yilun
2026-08-21 3:29 ` [PATCH 1/6] x86/virt/tdx: Wrap TDH.SYS.CONFIG/UPDATE operations in helpers Xu Yilun
2026-08-21 20:53 ` Edgecombe, Rick P
2026-08-24 4:52 ` Xu Yilun
2026-08-21 3:29 ` [PATCH 2/6] x86/virt/tdx: Configure add-on features on TDX module init and update Xu Yilun
2026-08-21 14:38 ` Dave Hansen
2026-08-21 21:18 ` Edgecombe, Rick P
2026-08-24 6:37 ` Xu Yilun
2026-08-24 15:15 ` Dave Hansen
2026-08-24 18:34 ` Xu Yilun
2026-08-21 22:01 ` Edgecombe, Rick P
2026-08-21 3:29 ` [PATCH 3/6] x86/virt/tdx: Detect if the extensions initialization is required Xu Yilun
2026-08-21 15:22 ` Kiryl Shutsemau
2026-08-21 22:22 ` Edgecombe, Rick P
2026-08-24 12:16 ` Kiryl Shutsemau
2026-08-21 3:29 ` [PATCH 4/6] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-08-21 15:44 ` Kiryl Shutsemau
2026-08-24 9:18 ` Xu Yilun
2026-08-24 12:22 ` Kiryl Shutsemau
2026-08-21 3:29 ` [PATCH 5/6] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-08-21 23:55 ` Edgecombe, Rick P
2026-08-24 17:14 ` Xu Yilun
2026-08-24 17:43 ` Edgecombe, Rick P
2026-08-25 9:53 ` Xu Yilun
2026-08-24 17:58 ` Edgecombe, Rick P
2026-08-25 10:02 ` Xu Yilun
2026-08-21 3:29 ` [PATCH 6/6] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun
2026-08-22 0:01 ` Edgecombe, Rick P
2026-08-25 8:35 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao1T61FjnTQwa6qN@tlindgre-MOBL1 \
--to=tony.lindgren@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.fang@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sohil.mehta@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox