Linux Confidential Computing Development
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Rick P Edgecombe <rick.p.edgecombe@intel.com>
Cc: "kas@kernel.org" <kas@kernel.org>, "bp@alien8.de" <bp@alien8.de>,
	 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	 "krzk@kernel.org" <krzk@kernel.org>,
	"au.dang.jx@renesas.com" <au.dang.jx@renesas.com>,
	 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	 "biju.das.jz@bp.renesas.com" <biju.das.jz@bp.renesas.com>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	 "biju.das.au@gmail.com" <biju.das.au@gmail.com>,
	"jirislaby@kernel.org" <jirislaby@kernel.org>,
	 "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	 "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	 "linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH -v2] MAINTAINERS: Fix Intel TDX kernel file patterns
Date: Mon, 2 Nov 2026 12:07:18 -0800	[thread overview]
Message-ID: <aujtdn73XnWH5g-i@google.com> (raw)
In-Reply-To: <953b3d774dc281bf13f5025041d4434f560cf776.camel@intel.com>

On Mon, Nov 02, 2026, Rick P Edgecombe wrote:
> On Fri, 2026-10-30 at 20:01 -0700, Borislav Petkov wrote:
> > From: "Borislav Petkov (AMD)" <bp@alien8.de>
> > 
> > A K: is a content regex file pattern which matches any text in a patch
> > so if a commit message contains "tdx" as in
> > 
> >   has_tdxe_auto_clear
> > 
> > for example, see
> > 
> >   https://lore.kernel.org/r/20261026-g2ul_sci-v3-3-b3097163edd5@bp.renesas.com
> > 
> > get_maintainer.pl erroneously adds the x86 gang to the Cc list for what
> > obviously is a completely unrelated patch.
> > 
> > The same happens when someone uses it to check
> > 
> >   drivers/power/reset/tdx-ec-poweroff.c
> > 
> > patches.
> > 
> > So switch the x86 TDX patterns to files and directories (F:) wildcard
> > type patterns and group them by path, for less false positives.
> > 
> > Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> > Link:
> > https://lore.kernel.org/r/20261027055750.GBauA9XlPykc1c1Xhv@fat_crate.local
> > ---
> >  MAINTAINERS | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7a162e9bcab1..015cf66afb96 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -30347,8 +30347,11 @@ L:	linux-coco@lists.linux.dev
> >  L:	kvm@vger.kernel.org
> >  S:	Supported
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/tdx
> > -N:	tdx
> > -K:	\b(tdx)
> > +F:	arch/x86/**/*tdx*
> > +F:	Documentation/**/*tdx*
> > +F:	drivers/virt/coco/tdx*/
> > +F:	include/uapi/linux/tdx
> > +F:	tools/testing/selftests/tdx/
> 
> This drops arch/x86/kvm/vmx/tdx.c. Not that we are sending any PRs based on this
> maintainer entry, but I'd like to continue to keep tabs on that code.
> 
> Sean do you have any thoughts about how this entry applies to the KVM side of
> TDX? I'm not sure we actually ever had a specific discussion.

Honestly, it annoys me.  I often temporarily delete the TDX MAINTAINERS entry when
sending patches that affect arch/x86/kvm/vmx/tdx.c, because many, if not most, of
the KVM changes are purely mechanical and/or KVM-internal that don't have much to
do with TDX as a whole.  Although maybe that's just a reflection of the types of
patches I tend to send.

But I do that purely to try and not pollute x86@ and linux-coco@ with stuff I'm
99.9% certain they don't care about.  If y'all want to sign up for spam, I won't
stop you. :-D

> In practice it has been a cross subsystem wrangler role. With TDX connect it
> will likely grow more tentacles.

      parent reply	other threads:[~2026-11-02 20:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 11:23 [PATCH v3 0/4] Fix transmit handling on SCI/RSCI ports Biju Das
2026-10-26 11:23 ` [PATCH v3 1/4] serial: sh-sci: Drop TE disable at end of transmission on SCI Biju Das
2026-10-26 11:23 ` [PATCH v3 2/4] serial: sh-sci: Keep TX enabled on TEI while data is pending Biju Das
2026-10-26 11:23 ` [PATCH v3 3/4] serial: sh-sci: Skip TDxE clear when hardware clears it automatically Biju Das
2026-10-26 11:23 ` [PATCH v3 4/4] serial: sh-sci: Toggle TE when restoring SCSCR in console write on SCI Biju Das
2026-10-27  5:57 ` [PATCH v3 0/4] Fix transmit handling on SCI/RSCI ports Borislav Petkov
2026-10-27  7:19   ` Biju Das
2026-10-27  7:23     ` Krzysztof Kozlowski
2026-10-27  8:33       ` Biju Das
2026-10-27  9:34         ` Krzysztof Kozlowski
2026-10-27 20:54           ` Borislav Petkov
2026-10-28  9:13             ` Biju Das
2026-10-28 11:02             ` Krzysztof Kozlowski
2026-10-28 15:47               ` Borislav Petkov
2026-10-30  2:33                 ` [PATCH] MAINTAINERS: Fix Intel TDX kernel file patterns Borislav Petkov
2026-10-30 14:17                   ` Dave Hansen
2026-10-30 14:40                   ` Kiryl Shutsemau
2026-10-30 18:22                     ` Borislav Petkov
2026-10-30 17:16                   ` Joe Perches
2026-10-30 18:20                     ` Borislav Petkov
2026-10-30 19:40                       ` Joe Perches
2026-10-30 19:49                         ` Borislav Petkov
2026-10-31  3:01                   ` [PATCH -v2] " Borislav Petkov
2026-10-31 16:43                     ` Joe Perches
2026-10-31 20:27                       ` Borislav Petkov
2026-10-31 22:52                         ` Joe Perches
2026-10-31 23:59                           ` Borislav Petkov
2026-11-01  0:38                             ` Joe Perches
2026-11-01  1:47                               ` Borislav Petkov
2026-11-01  5:35                                 ` Joe Perches
2026-11-01 18:54                                   ` Borislav Petkov
2026-11-01 18:59                                     ` Joe Perches
2026-11-01 19:37                                       ` Borislav Petkov
2026-11-01 19:54                                         ` Joe Perches
2026-11-01 20:17                                           ` Borislav Petkov
2026-11-02 19:38                     ` Edgecombe, Rick P
2026-11-02 19:49                       ` Borislav Petkov
2026-11-02 19:56                         ` Edgecombe, Rick P
2026-11-02 20:07                       ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aujtdn73XnWH5g-i@google.com \
    --to=seanjc@google.com \
    --cc=au.dang.jx@renesas.com \
    --cc=biju.das.au@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kas@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox