From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979D1AD31 for ; Tue, 10 Sep 2024 00:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725927527; cv=none; b=dbXEMU2bCcRmEUI7m8b5FPLGJEmYO+wGsCuY6cdPH9+HR31iIqUD5uR+TL662gjx5iD1gYoOT3SgtYVT+Ow8G11wb7w7SP5PG/V6EMpPA2/iQ8tqvSdnSSPiW9VDjvHjB0xPCgy3uIqVfWE00nBdFcekC14sAdqltWleA7z0iT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725927527; c=relaxed/simple; bh=L3a2g1E/6DmPzoCid4NmrExadsFZujU2lIAaLeWmoB0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dh35lFWshYzvSBwJhi5zxlbYbdaWLCZ9cjfSuSkfEYl0woG2o2Jh7b7Zea3FAi1bXZeTkQOOc2dWnYcAedeA4GrSpGFhRb3MS0MVov3tZbAu6DDDT2v1zSMbhrvqh6xxZeUe+AgIHm8DL9puhnO8uTpUWnId738gkGhsgVLDz34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HbmVZlYj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HbmVZlYj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725927524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3qDUKZkW1qm/U7nIsNHl6u/vxYb3LmdiiRvhpMXyqBg=; b=HbmVZlYjLV/FzAiTvJ1wpeLM0praOaMuYBvMoCTmBOxgx//L9lIekaNW1MtwSS9YMa36wR YO4FzqoECpn25MrUzNn+R66D6nK1iqQG89ZzbXVJV3Di3/y/lnH1f04kP3zz+q8C+e+KMO KpKOnNZEVFMOt+mKT54IJ3Mq+aUi6nk= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-5vIBOuDjMhqFPEJKRdzdzQ-1; Mon, 09 Sep 2024 20:18:43 -0400 X-MC-Unique: 5vIBOuDjMhqFPEJKRdzdzQ-1 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7179469744dso288200b3a.2 for ; Mon, 09 Sep 2024 17:18:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725927522; x=1726532322; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3qDUKZkW1qm/U7nIsNHl6u/vxYb3LmdiiRvhpMXyqBg=; b=wSMYsnJ0mAUslQ0SHVLHLUOf2EkVf85GXMGQ7M0US3HUovm1hNehsm9/LEe1/c8AXW YvQVCosey+bYBUqqrGhnCiwz9dS+kJ8rslAmov2Ysbq7q9wHrwAYbcztN8kP+rVukw2W ElOT9AEaz6THqRqlW0BCKBhuys2DyunkbYd7qxgkQCM6vVCQjY2DMaBFzyL3R7rQB1CQ YK6PjLhSysEOVDMlo3O6/X/BYhcYMRRPHVSPgpTmaXsDi8ffkTDleAKsInaCbbVlP7y7 1TSHA+J4amEE+thUJcHomDpGpJly+xSWWi0Vq8OY7h3YlCQPtjToi1orXC9338hIFL1k gbrQ== X-Forwarded-Encrypted: i=1; AJvYcCUf3fDYieyhUaiNtrGS2VPILFj2dWp0ZF27Kh1WR5WBU7teNMIPJxzJAr99bJd5+YsAQoUzjLf3723+@lists.linux.dev X-Gm-Message-State: AOJu0YypFRHOqySVRtJUInVLZWHLuPKR8uXgNybn895dgllRi0/rTKtM GGBN6m3PW19YphpPqWp7A0jl/mRJBmzEXzmwiq3xXGhxBhW00SKI65f5sm1Un/rXTCZs+EDLTvw PyCiirb5v8sP73FjBLizAasJfeIr6LDjtEGeUeKouReajyNporL5iWGDoD4Y= X-Received: by 2002:a05:6a00:3cc4:b0:718:d7de:3be2 with SMTP id d2e1a72fcca58-718e33a0050mr14892309b3a.14.1725927521923; Mon, 09 Sep 2024 17:18:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyd0cypr7QA7LSQQ0FAqADYQZb+J27E549rmhRMytoKbFbGfFE8ni5SsRVpLPAZanhv86dsg== X-Received: by 2002:a05:6a00:3cc4:b0:718:d7de:3be2 with SMTP id d2e1a72fcca58-718e33a0050mr14892272b3a.14.1725927521353; Mon, 09 Sep 2024 17:18:41 -0700 (PDT) Received: from [192.168.68.54] ([103.210.27.31]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7190909222bsm284268b3a.115.2024.09.09.17.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2024 17:18:40 -0700 (PDT) Message-ID: Date: Tue, 10 Sep 2024 10:18:31 +1000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/19] arm64: realm: Query IPA size from the RMM To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun References: <20240819131924.372366-1-steven.price@arm.com> <20240819131924.372366-7-steven.price@arm.com> From: Gavin Shan In-Reply-To: <20240819131924.372366-7-steven.price@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/19/24 11:19 PM, Steven Price wrote: > The top bit of the configured IPA size is used as an attribute to > control whether the address is protected or shared. Query the > configuration from the RMM to assertain which bit this is. > > Co-developed-by: Suzuki K Poulose > Signed-off-by: Suzuki K Poulose > Signed-off-by: Steven Price > --- > Changes since v4: > * Make PROT_NS_SHARED check is_realm_world() to reduce impact on > non-CCA systems. > Changes since v2: > * Drop unneeded extra brackets from PROT_NS_SHARED. > * Drop the explicit alignment from 'config' as struct realm_config now > specifies the alignment. > --- > arch/arm64/include/asm/pgtable-prot.h | 4 ++++ > arch/arm64/kernel/rsi.c | 8 ++++++++ > 2 files changed, 12 insertions(+) > One nit below. Reviewed-by: Gavin Shan > diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h > index b11cfb9fdd37..5e578274a3b7 100644 > --- a/arch/arm64/include/asm/pgtable-prot.h > +++ b/arch/arm64/include/asm/pgtable-prot.h > @@ -68,8 +68,12 @@ > > #include > #include > +#include > > extern bool arm64_use_ng_mappings; > +extern unsigned long prot_ns_shared; > + > +#define PROT_NS_SHARED (is_realm_world() ? prot_ns_shared : 0) > > #define PTE_MAYBE_NG (arm64_use_ng_mappings ? PTE_NG : 0) > #define PMD_MAYBE_NG (arm64_use_ng_mappings ? PMD_SECT_NG : 0) > diff --git a/arch/arm64/kernel/rsi.c b/arch/arm64/kernel/rsi.c > index 128a9a05a96b..e968a5c9929e 100644 > --- a/arch/arm64/kernel/rsi.c > +++ b/arch/arm64/kernel/rsi.c > @@ -8,6 +8,11 @@ > #include > #include > > +struct realm_config config; > + > +unsigned long prot_ns_shared; > +EXPORT_SYMBOL(prot_ns_shared); > + > DEFINE_STATIC_KEY_FALSE_RO(rsi_present); > EXPORT_SYMBOL(rsi_present); > > @@ -72,6 +77,9 @@ void __init arm64_rsi_init(void) > return; > if (!rsi_version_matches()) > return; > + if (rsi_get_realm_config(&config)) > + return; > + prot_ns_shared = BIT(config.ipa_bits - 1); > > static_branch_enable(&rsi_present); > } Nit: It's probably worthy to warn on errors returned from rsi_get_realm_config(), It's hard to debug and follow if it fails silently. Thanks, Gavin