From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06F003AFD1A for ; Mon, 8 Jun 2026 08:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907670; cv=none; b=PoeaTiYZUUaipujZf/BHoAcmixqamWmOo32oSjoRWyBYkUxvSmZ4Wm9LctoF5UBCBuec+JCVQUqObAn6ld/GQj0McaWcmT6Mtbl+u5WrArUA1DaFsAtbE4/P2v1rvu210yNBejAlwk1bUNFHrtWwXhT9fTUJCTI0TkXrE9CY+hw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907670; c=relaxed/simple; bh=FnQ1JtRVzrteGPjxYql2+zcjsPi1FKMeGzG2Ym0Gt/U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CUAUIXfxt8FcebyK3nT13glYlu2ZlFTIH3Y3A3RkCL/UuzFN/hOLIZ7IUiQU5+CR19mtFKohmo8wK0J0OBarwqGKTtq0BHmig7D5iK76r/7dDyJRjDbqZ3TIXPFT42FU/BX9StV43BHz6AY1MF2ZAVlaaAKVJbOSM0JZX0NfiUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cB43R7s+; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cB43R7s+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780907667; x=1812443667; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FnQ1JtRVzrteGPjxYql2+zcjsPi1FKMeGzG2Ym0Gt/U=; b=cB43R7s+NsDIC5AoT1wrY81vutlIviGcdbTpEwHB+QtnPYs/HNH+y18j 38Gjf2Td0inROWncoex6B3PNGs+3c2cnu2PzeJ5j/FyMruOSzLNJdbEpe qSitApVQQMeO0amSG8YogTh93vi5Ca/myZBrm/C4ZrbIhjp3iNQjcD3rI Swgls5nEPKIB1u5C7s/uiDNEmKWRz7+LDLETKNe6BdLG9RWRIpAx4ZQUe EiqaOuoaoRl+2TFM94O/lFFK+a+HTYk9mEITagOVC+rNy6Q+5NkxihfeU nRdIhgqPm7gT7xh2QjVRkp/4xFIbj6fVrffi2DzbbCra6n9mhxRNFJiI6 g==; X-CSE-ConnectionGUID: bEHadQ1qQYSZ2p4Za09C6Q== X-CSE-MsgGUID: 62AqYXYlTJ6iRHStizvYcA== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="93027188" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="93027188" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 01:34:25 -0700 X-CSE-ConnectionGUID: Vir/7hP/TfWq59yzcSm1/w== X-CSE-MsgGUID: +bKIBP4fSUKCyspCfRmD+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="269463675" Received: from unknown (HELO [10.238.2.24]) ([10.238.2.24]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 01:34:17 -0700 Message-ID: Date: Mon, 8 Jun 2026 16:34:15 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 15/22] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu To: Lisa Wang Cc: Andrew Jones , Ackerley Tng , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Oliver Upton , Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260521-tdx-selftests-v13-v13-0-6983ae4c3a4d@google.com> <20260521-tdx-selftests-v13-v13-15-6983ae4c3a4d@google.com> Content-Language: en-US From: Binbin Wu In-Reply-To: <20260521-tdx-selftests-v13-v13-15-6983ae4c3a4d@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/2026 7:16 AM, Lisa Wang wrote: [...]> diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > index 9660ea9d2f31..4d01f806b37d 100644 > --- a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > @@ -39,6 +39,30 @@ static inline bool is_tdx_vm(struct kvm_vm *vm) > __TEST_ASSERT_VM_VCPU_IOCTL(!ret, #cmd, ret, vm); \ > }) > > +#define __tdx_vcpu_ioctl(vcpu, cmd, _flags, arg) \ > +({ \ > + int r; \ > + \ > + union { \ > + struct kvm_tdx_cmd c; \ > + unsigned long raw; \ > + } tdx_cmd = { .c = { \ > + .id = (cmd), \ > + .flags = (u32)(_flags), \ > + .data = (u64)(arg), \ Nit: The two lines' backslashes are misaligned. > + } }; \ > + \ > + r = __vcpu_ioctl(vcpu, KVM_MEMORY_ENCRYPT_OP, &tdx_cmd.raw); \ > + r ?: tdx_cmd.c.hw_error; \ Similar issue of the truncation of upper bits. Though TDX KVM code never sets hw_error currently for vcpu version. > +}) > + > +#define tdx_vcpu_ioctl(vcpu, cmd, flags, arg) \ > +({ \ > + int ret = __tdx_vcpu_ioctl(vcpu, cmd, flags, arg); \ > + \ > + __TEST_ASSERT_VM_VCPU_IOCTL(!ret, #cmd, ret, (vcpu)->vm); \ > +}) > + > void tdx_init_vm(struct kvm_vm *vm, u64 attributes); > void tdx_vm_setup_boot_code_region(struct kvm_vm *vm); > void tdx_vm_setup_boot_parameters_region(struct kvm_vm *vm, u32 nr_runnable_vcpus);