From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>, "bp@alien8.de" <bp@alien8.de>,
"Hansen, Dave" <dave.hansen@intel.com>
Cc: "sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH 1/2] x86/kexec: Preserve CR4.MCE during kexec
Date: Thu, 16 Feb 2023 01:49:39 +0000 [thread overview]
Message-ID: <bcaf4b7121e20ba27dd2cc2b347feb35ae7bfa53.camel@intel.com> (raw)
In-Reply-To: <20230213234836.3683-2-kirill.shutemov@linux.intel.com>
On Tue, 2023-02-14 at 02:48 +0300, Kirill A. Shutemov wrote:
> TDX guests are not allowed to clear CR4.MCE. Attempt to clear it
> leads
> to #VE.
>
> Preserve the flag during kexec.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
I wonder whats going on with the pre-existing switching between eax and
rax in this code for the cr0 and cr4 manipulations. Do you know what
the reason is?
Also, for a simple non-tdx kexec regression test:
Tested-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
next prev parent reply other threads:[~2023-02-16 1:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 23:48 [PATCH 0/2] Kexec enabling in TDX guest Kirill A. Shutemov
2023-02-13 23:48 ` [PATCH 1/2] x86/kexec: Preserve CR4.MCE during kexec Kirill A. Shutemov
2023-02-16 1:49 ` Edgecombe, Rick P [this message]
2023-02-16 9:43 ` Kirill A. Shutemov
2023-02-16 17:33 ` Edgecombe, Rick P
2023-02-16 19:46 ` Andrew Cooper
2023-02-13 23:48 ` [PATCH 2/2] x86/tdx: Convert shared memory back to private on kexec Kirill A. Shutemov
2023-02-15 1:53 ` Huang, Kai
2023-02-16 17:50 ` [PATCH 0/2] Kexec enabling in TDX guest Dave Hansen
2023-02-16 18:12 ` Kirill A. Shutemov
2023-02-16 18:32 ` Dave Hansen
2023-02-22 10:26 ` David Woodhouse
2023-02-24 14:30 ` Kirill A. Shutemov
2023-02-24 15:22 ` Dave Hansen
2023-02-24 16:12 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcaf4b7121e20ba27dd2cc2b347feb35ae7bfa53.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kexec@lists.infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).