From: Guorui Yu <GuoRui.Yu@linux.alibaba.com>
To: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
konrad.wilk@oracle.com, linux-coco@lists.linux.dev
Cc: robin.murphy@arm.com
Subject: Re: [PATCH 2/4] swiotlb: Add a new cc-swiotlb implementation for Confidential VMs
Date: Sun, 29 Jan 2023 09:54:30 +0800 [thread overview]
Message-ID: <bde64a70-7d9c-9e85-cd02-0301d4a0838e@linux.alibaba.com> (raw)
In-Reply-To: <c966018b-95f0-7b92-0a5a-9023236b0dfb@infradead.org>
Hi Randy,
在 2023/1/29 00:41, Randy Dunlap 写道:
> Hi--
>
> On 1/28/23 00:32, GuoRui.Yu wrote:
>> diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
>> index 56866aaa2ae1..7e6b20d2091f 100644
>> --- a/kernel/dma/Kconfig
>> +++ b/kernel/dma/Kconfig
>> @@ -78,8 +78,18 @@ config ARCH_HAS_FORCE_DMA_UNENCRYPTED
>>
>> config SWIOTLB
>> bool
>> + depends on !CC_SWIOTLB
>> select NEED_DMA_MAP_STATE
>>
>> +config CC_SWIOTLB
>> + bool "Enable cc-swiotlb for Confidential VMs"
>> + default n
>> + select NEED_DMA_MAP_STATE
>> + help
>> + This enables a cc-swiotlb implementation for Confidential VMs,
>> + which allows allocating the SWIOTLB buffer allocation on runtime.
>
> Two "allocat..." words seems to be redundant. Probably the second one
> can be dropped.
> Also, instead of "on runtime", how about "at runtime"?
Thanks for your kindly advice, and I will fix it in the next version.
>
>> + If unsure, say "n".
>
> Thanks.
Sincerely,
Guorui
next prev parent reply other threads:[~2023-01-29 1:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 8:32 [RFC] swiotlb: Add a new cc-swiotlb implementation for Confidential VMs GuoRui.Yu
2023-01-28 8:32 ` [PATCH 1/4] swiotlb: Split common code from swiotlb.{c,h} GuoRui.Yu
2023-01-28 8:32 ` [PATCH 2/4] swiotlb: Add a new cc-swiotlb implementation for Confidential VMs GuoRui.Yu
2023-01-28 12:03 ` kernel test robot
2023-01-28 16:41 ` Randy Dunlap
2023-01-29 1:54 ` Guorui Yu [this message]
2023-01-29 16:58 ` Andi Kleen
2023-01-30 2:25 ` Guorui Yu
2023-01-30 6:46 ` Andi Kleen
2023-01-30 13:45 ` Guorui Yu
2023-01-31 17:16 ` Andi Kleen
2023-02-01 2:08 ` Guorui Yu
2023-01-28 8:32 ` [PATCH 3/4] swiotlb: Add tracepoint swiotlb_unbounced GuoRui.Yu
2023-01-28 8:32 ` [PATCH 4/4] cc-swiotlb: Allow set swiotlb watermark from cmdline GuoRui.Yu
2023-01-28 20:19 ` kernel test robot
2023-01-28 9:03 ` [RFC] swiotlb: Add a new cc-swiotlb implementation for Confidential VMs Guorui Yu
2023-01-30 6:54 ` Christoph Hellwig
2023-01-30 13:03 ` Robin Murphy
2023-01-30 14:37 ` Guorui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde64a70-7d9c-9e85-cd02-0301d4a0838e@linux.alibaba.com \
--to=guorui.yu@linux.alibaba.com \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).