From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-8.freemail.mail.aliyun.com (out30-8.freemail.mail.aliyun.com [115.124.30.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8418BD05 for ; Sun, 29 Jan 2023 01:59:52 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=guorui.yu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VaIuoBd_1674957271; Received: from 192.168.51.205(mailfrom:GuoRui.Yu@linux.alibaba.com fp:SMTPD_---0VaIuoBd_1674957271) by smtp.aliyun-inc.com; Sun, 29 Jan 2023 09:54:32 +0800 Message-ID: Date: Sun, 29 Jan 2023 09:54:30 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/4] swiotlb: Add a new cc-swiotlb implementation for Confidential VMs To: Randy Dunlap , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, konrad.wilk@oracle.com, linux-coco@lists.linux.dev Cc: robin.murphy@arm.com References: <20230128083254.86012-1-GuoRui.Yu@linux.alibaba.com> <20230128083254.86012-3-GuoRui.Yu@linux.alibaba.com> From: Guorui Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Randy, 在 2023/1/29 00:41, Randy Dunlap 写道: > Hi-- > > On 1/28/23 00:32, GuoRui.Yu wrote: >> diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig >> index 56866aaa2ae1..7e6b20d2091f 100644 >> --- a/kernel/dma/Kconfig >> +++ b/kernel/dma/Kconfig >> @@ -78,8 +78,18 @@ config ARCH_HAS_FORCE_DMA_UNENCRYPTED >> >> config SWIOTLB >> bool >> + depends on !CC_SWIOTLB >> select NEED_DMA_MAP_STATE >> >> +config CC_SWIOTLB >> + bool "Enable cc-swiotlb for Confidential VMs" >> + default n >> + select NEED_DMA_MAP_STATE >> + help >> + This enables a cc-swiotlb implementation for Confidential VMs, >> + which allows allocating the SWIOTLB buffer allocation on runtime. > > Two "allocat..." words seems to be redundant. Probably the second one > can be dropped. > Also, instead of "on runtime", how about "at runtime"? Thanks for your kindly advice, and I will fix it in the next version. > >> + If unsure, say "n". > > Thanks. Sincerely, Guorui