Re: [PATCH] x86/kvm/tdx: Save %rbp in TDX_MODULE_CALL

Dave Hansen
2024-05-17T15:16:31Z

On 5/17/24 07:44, Juergen Gross wrote:
> Just another data point: Before using this machine I was testing on
> another one with older firmware. That one really didn't support NOM_RBP_MOD
> and I needed to build the kernel with CONFIG_FRAME_POINTER enabled to get
> past the check you are mentioning above.

For all intents and purposes, the modules that intentionally clobber RBP
don't support Linux. If buggy modules are accidentally clobbering RBP,
we can debate how much the kernel should bend over to accommodate them,
but my preference would be to ignore them.

I'd much rather put a deny list in the kernel than try to tolerate RBP
clobbering universally.