From: Tom Lendacky <thomas.lendacky@amd.com>
To: Cole Robinson <crobinso@redhat.com>, Borislav Petkov <bp@suse.de>
Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
brijesh.singh@amd.com
Subject: Re: [PATCH] virt: sev-guest: Add MODULE_ALIAS
Date: Mon, 7 Nov 2022 08:09:08 -0600 [thread overview]
Message-ID: <c40b0b21-2a48-ffff-6568-fb55e8f9a15c@amd.com> (raw)
In-Reply-To: <91c2eaad-92fc-4251-f9e9-7d73cf2b5da5@redhat.com>
On 11/5/22 11:08, Cole Robinson wrote:
> On 11/4/22 4:53 PM, Borislav Petkov wrote:
>> On Fri, Nov 04, 2022 at 04:42:45PM -0400, Cole Robinson wrote:
>>> This fixes driver autoloading
>>
>> What is the scenario where this needs to be autoloaded?
>>
>
> Any use case that needs /dev/sev-guest, I guess. Saves software from
> having to do the modprobe manually. For example, nothing I can find in
> https://github.com/AMDESE/sev-guest loads the driver, it expects
> /dev/sev-guest to be there already
>
> Mostly I assumed lack of autoloading was an oversight. Was it
> intentionally omitted?
It probably was an oversight. To me, it makes sense to auto-load the
module if the SNP support created the platform device as part of SNP
initialization.
Thanks,
Tom
>
> Thanks,
> Cole
>
next prev parent reply other threads:[~2022-11-07 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 20:42 [PATCH] virt: sev-guest: Add MODULE_ALIAS Cole Robinson
2022-11-04 20:53 ` Borislav Petkov
2022-11-05 16:08 ` Cole Robinson
2022-11-07 14:09 ` Tom Lendacky [this message]
2022-11-07 22:10 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40b0b21-2a48-ffff-6568-fb55e8f9a15c@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=crobinso@redhat.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).