From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EB7F84E04 for ; Sat, 12 Oct 2024 05:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728710542; cv=none; b=EiBw8u1nDY1Uu3F871mID923cBrlD2v+/h1kDAkzxiWov+0oJDtPvrX84SjbcgDX22w1YPq6eHPcFLQ1J2Ok8Lh2FoDz90ewO5btPQ7vJypPa0VyHPL2d64OUFUeLIrvZKsGBDmpZqLCA35neakf1sXkFGvxSw+EKralYeaX6bA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728710542; c=relaxed/simple; bh=KP48yn2zu/bvXJGE9dWPkWLMt3oDQ+5HzzzKc0IzQwg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n51nwPJUrSN9bcFIevcOkrzwIIhdAQT+wmTp7FaP7UIow4Sn6iZAAZiwaST++8N6dOTrXFacl1LE77nz1ik4YXsv6kI4VusJfOxbtKTFOlTTQanlbh8+ZoUaYfRoBWQ+kfwwfcEhPT7FYvAJbDr8sRoXqAFNt8EelOKM/BA1dv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MNOpvjdL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MNOpvjdL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728710539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hvDr0hBqceMPoqKr59VTJA2PMmkK0w6bfmvafMG1XxI=; b=MNOpvjdLSEnqc7pFQ75u2tS7yhjbJVcTm2O0O59cyRpka5Z+83gKJ7y6Xy34fP0l1A7t7f QL882BzacaUpF8VfjFjpEaAboQhPAfb1SN8ToqqNidd93pvmOOJDt4LFppJYJQVJvaQrdf fdJzMx7Vr3R+SHYnymQEe8MG53CTUtE= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-Nu89bvhsNLWPAJQxu8D2EQ-1; Sat, 12 Oct 2024 01:22:17 -0400 X-MC-Unique: Nu89bvhsNLWPAJQxu8D2EQ-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-7cd9ac1fa89so3306142a12.1 for ; Fri, 11 Oct 2024 22:22:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728710536; x=1729315336; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvDr0hBqceMPoqKr59VTJA2PMmkK0w6bfmvafMG1XxI=; b=sOWUikjzgk0WL5C1uK6VLhQ2sS58KydhagVUEDch+xPmXhtP8ERbw3pYOLk0q8By7M NM8XOa43Ujx7hf/dujTsxdsvXmuB+6TvDooReQxHj9Quod98/a77CSJG13FZqLdERZ0u en1CFLkoLn7EVM1nI26okQMlYOkVuO2d1wlTYTdTKMwhnov0G0iRRGiiVA9Ygk8S6joP euBFBUx8L5YnGIkMQ3ijRNtnqoi00G239hUeQWXTqPN3imyfbpkd9ekR+38yCkDxF2M8 5iEoF+ai0Ahv04eV1lFi1DLNZV69HVnx97TvWVRhTD/fkGVR0TJSf2Yw48dVy+Qq/h/K dodA== X-Forwarded-Encrypted: i=1; AJvYcCXUnb1HbA6p7kvQoS5XOK7fVz/B9sT2QXftpb6Lms3WN2X/XZ8EuE6jO5abUthe49k4xuGZNlxIB4Xd@lists.linux.dev X-Gm-Message-State: AOJu0YztNJnbaV+hAfduelK9JO6JpcbnWjtPUuirbgPonrlxVBNCHnA3 SbsCmmmejixPMydQMdDcsX8wSVsbaS698xHGu3GLmW3xjSkXTf1hBO9g8pZppDc3waQnM04W28q qs7eeZeCMXAJfAOrygZtb/j0NGtPoa5QIzPh/Mk7qoHJm2SblFp0gdqVEmzw= X-Received: by 2002:a17:903:2292:b0:20c:be0e:d47e with SMTP id d9443c01a7336-20cbe0ed77fmr27330325ad.56.1728710536276; Fri, 11 Oct 2024 22:22:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPdfPL4sLDuZbuEZ8hOCaoZXNRre8SGr7tfbn9VtHIuESumtQnMGZco/QwYJ9wvIb8IjS+5g== X-Received: by 2002:a17:903:2292:b0:20c:be0e:d47e with SMTP id d9443c01a7336-20cbe0ed77fmr27329915ad.56.1728710535801; Fri, 11 Oct 2024 22:22:15 -0700 (PDT) Received: from [192.168.68.54] ([180.233.125.129]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c33fdf9sm31443385ad.260.2024.10.11.22.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 22:22:15 -0700 (PDT) Message-ID: Date: Sat, 12 Oct 2024 15:22:06 +1000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 05/11] arm64: rsi: Map unprotected MMIO as decrypted To: Catalin Marinas Cc: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev, Suzuki K Poulose , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" References: <20241004144307.66199-1-steven.price@arm.com> <20241004144307.66199-6-steven.price@arm.com> From: Gavin Shan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/11/24 11:19 PM, Catalin Marinas wrote: > On Tue, Oct 08, 2024 at 10:31:06AM +1000, Gavin Shan wrote: >> On 10/5/24 12:43 AM, Steven Price wrote: >>> diff --git a/arch/arm64/kernel/rsi.c b/arch/arm64/kernel/rsi.c >>> index d7bba4cee627..f1add76f89ce 100644 >>> --- a/arch/arm64/kernel/rsi.c >>> +++ b/arch/arm64/kernel/rsi.c >>> @@ -6,6 +6,8 @@ >>> #include >>> #include >>> #include >>> + >>> +#include >>> #include >>> struct realm_config config; >>> @@ -92,6 +94,16 @@ bool arm64_is_protected_mmio(phys_addr_t base, size_t size) >>> } >>> EXPORT_SYMBOL(arm64_is_protected_mmio); >>> +static int realm_ioremap_hook(phys_addr_t phys, size_t size, pgprot_t *prot) >>> +{ >>> + if (arm64_is_protected_mmio(phys, size)) >>> + *prot = pgprot_encrypted(*prot); >>> + else >>> + *prot = pgprot_decrypted(*prot); >>> + >>> + return 0; >>> +} >>> + >> >> We probably need arm64_is_mmio_private() here, meaning arm64_is_protected_mmio() isn't >> sufficient to avoid invoking SMCCC call SMC_RSI_IPA_STATE_GET in a regular guest where >> realm capability isn't present. > > I think we get away with this since the hook won't be registered in a > normal guest (done from arm64_rsi_init()). So the additional check in > arm64_is_mmio_private() is unnecessary. > Indeed. I missed the point that the hook won't be registered for a normal guest. So we're good and safe. Thanks, Gavin