From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A73F01CAA7D for ; Tue, 3 Jun 2025 11:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748949746; cv=none; b=YdrPygQCheOg9k3hbNd1r2bb9HI4u4hCbDuTTllCkpfIrGN9YdFaWXPSV0zw40qVKVckH3oG1CbHqH2ZkQutzv8hcW+jA9dXKXPLHLo2FTsV+P08qH8OoRCB17oitwaUHBIeVQOopBe1BtKgKx9JP57YAN2z4PZnGBRRKVPuTcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748949746; c=relaxed/simple; bh=4bYe98B7YedxOKQs5dYV9Ing2H+ahxEuWbcKRNwu5jw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mqe9sjIpHNlt121Ox/Dx+hGznwbxCqu90WONG0OyR/XH+DyRz+rRO6Xh+tbTOX5UrnGhN7nKQeH5bQI9lxqcuNWcXNuiXzU805fVeJuCTGIG0TB4BzNugGpyWY6g6Zd+/rjc94itMV4zrDyNSJKqu+ipwD2OIm39yo8TwGF8/Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EDgTecuA; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EDgTecuA" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-451d6ade159so21032585e9.1 for ; Tue, 03 Jun 2025 04:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1748949743; x=1749554543; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=uGLHAt8DknR+WLbJkRe9iH2Js5SBq5tvVtKbx041tVU=; b=EDgTecuAENCvpZxu4Eyqh15j6NpmCfZNdEx2mYSC6sNbRb3SgLVeDm5vVA0PMULS+X SICx6hzb0A7ErlDT+7Ss+n2zlx2yYnxab17GTTM1JUN27gmVyOig5qb5Rb7Sb7dymvDZ i674AB0VNWL0maMSm/ktfXcXtc9rPn18jl3oIdAwMcHlzDyAZu9s1Jn4DPzQm95Yq1SJ K6/57o7NaySBqBmwvrUhBdykO95RRrGuPVV/tJWpP9MLzCrEMByQ8LffhYxeGcGFDYLS 0ecBJX7yFAUAwHeOV+yL89RB1tvpSFNJ0wR9tsNiL9mi2/Cd07vt3h9390a+nkgRCdiD Sy5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748949743; x=1749554543; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uGLHAt8DknR+WLbJkRe9iH2Js5SBq5tvVtKbx041tVU=; b=kTBMzKbromYpLQmSoAVQWVaQ7z2lzYtFjA1JYEYSHl4cZbziBwy34yYinNz4bROl0j pY9NRxUd6lrzKH/ZKhfovd8BGqFxDv6PQXn5vsQ+dRPs6iw/2JwbwoPqgaXRyG/C/1wJ 7JK0DIQLIZtGgGBGXnCq3EqxuLsdG6gWoIsUvtXghMmRDS00c53t5XivR1qdPXYA/Bok iXUF6OWbp98N1BWAEd+AShQB4tS7OyEiyDzO73TC8DpYsp5UMTIzEmohBshp131CoBoi fw/aWkQC9bWT48ThwAVS5EFayLFWis4VI9LfGOnZw7yBYsYCm6Irr3G5OA6pw45Hct9Q cQ/w== X-Forwarded-Encrypted: i=1; AJvYcCVrg1ayJ6Y4Els3QaKlEQf9hcGr0WK+U/yvtOlyhGiKEgP2DbybPhmx5C1dEiKTXHn2EAPQKBYra6cp@lists.linux.dev X-Gm-Message-State: AOJu0Yy8BmSWLJgfdUif6mhS7tpRfdOD3E4lHElCPdbvh8vaJ46agMOe V3w+a5t4kHCdS6gXz5BbMA1mWvZEn6xG3ipqp7GNiJ0EecpE8Esa93ReaN+3FEU9n38= X-Gm-Gg: ASbGnct6lLbhHbGx9rfCrLPJPCbKtAYHuE+89ywvH0QA1Ww46sR6RMfKm0L5pa2cjX3 3p1qE/SkQkVXoV7ficMTlzRpvC38yk2IkeWCTzxg+XMeinoH0y/vM5QTPqmpMd8XMyM5EgwUUEf baghMLaQROPCg11+V3t4tfZSc4UPWQbq+Gw6Vr7ws7XDILKBr2N9yP5vVkdEHbpGQbf5Ck5nMHt 0lXWJQVG6wj4G1QRbq1bU93x2qVAob3speldeIl2eb6omOmGIgxeJbEj6c+UdEb8EmPDxNtFIIU MzrbkS7hMw/wGQyYlmq6Pvgj1EhrsUzG+QsTfoYpJX9xfJUU8CYh3RBHJrvprrzEtAXaEQ7o6kt KdQ== X-Google-Smtp-Source: AGHT+IEgpygrOhv7gLK00yaoYV7PitKSJjxKjZv024rqcceSRp7/7s8ylWvMN2iyAVhCspNkUGxhTg== X-Received: by 2002:a05:600c:1c8f:b0:43c:f70a:2af0 with SMTP id 5b1f17b1804b1-4511edd5bfamr127061965e9.16.1748949742895; Tue, 03 Jun 2025 04:22:22 -0700 (PDT) Received: from [192.168.0.20] ([212.21.159.167]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe6c8f5sm17608560f8f.27.2025.06.03.04.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 04:22:22 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 14:22:20 +0300 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 03/20] x86/virt/seamldr: Introduce a wrapper for P-SEAMLDR SEAMCALLs To: Chao Gao , linux-coco@lists.linux.dev, x86@kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com, pbonzini@redhat.com, eddie.dong@intel.com, kirill.shutemov@intel.com, dave.hansen@intel.com, dan.j.williams@intel.com, kai.huang@intel.com, isaku.yamahata@intel.com, elena.reshetova@intel.com, rick.p.edgecombe@intel.com, Farrah Chen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org References: <20250523095322.88774-1-chao.gao@intel.com> <20250523095322.88774-4-chao.gao@intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20250523095322.88774-4-chao.gao@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/23/25 12:52, Chao Gao wrote: > P-SEAMLDR is another component alongside the TDX module within the > protected SEAM range. Software can invoke its functions by executing the > SEAMCALL instruction with the 63 bit of RAX set to 1. P-SEAMLDR SEAMCALLs > differ from those of the TDX module in terms of error codes and the > handling of the current VMCS. > > Add a wrapper for P-SEAMLDR SEAMCALLs based on the SEAMCALL infrastructure. > > Intel® Trust Domain CPU Architectural Extensions (May 2021 edition) > Chapter 2.3 states: > > SEAMRET from the P-SEAMLDR clears the current VMCS structure pointed to by > the current-VMCS pointer. A VMM that invokes the P-SEAMLDR using SEAMCALL > must reload the current-VMCS, if required, using the VMPTRLD instruction. > > So, save and restore the current-VMCS pointer using VMPTRST and VMPTRLD > instructions to avoid breaking KVM, which manages the current-VMCS. > > Disable interrupts to prevent KVM code from interfering with P-SEAMLDR > SEAMCALLs. For example, if a vCPU is scheduled before the current VMCS is > restored, it may encounter an invalid current VMCS, causing its VMX > instruction to fail. Additionally, if KVM sends IPIs to invalidate a > current VMCS and the invalidation occurs right after the current VMCS is > saved, that VMCS will be reloaded after P-SEAMLDR SEAMCALLs, leading to > unexpected behavior. > > NMIs are not a problem, as the only scenario where instructions relying on > the current-VMCS are used is during guest PMI handling in KVM. This occurs > immediately after VM exits with IRQ and NMI disabled, ensuring no > interference with P-SEAMLDR SEAMCALLs. > > Signed-off-by: Chao Gao > Tested-by: Farrah Chen > --- > arch/x86/Kconfig | 10 ++++++++ > arch/x86/virt/vmx/tdx/Makefile | 1 + > arch/x86/virt/vmx/tdx/seamldr.c | 44 +++++++++++++++++++++++++++++++++ > arch/x86/virt/vmx/vmx.h | 40 ++++++++++++++++++++++++++++++ > 4 files changed, 95 insertions(+) > create mode 100644 arch/x86/virt/vmx/tdx/seamldr.c > create mode 100644 arch/x86/virt/vmx/vmx.h > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 4b9f378e05f6..8b1e0986b7f8 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1932,6 +1932,16 @@ config INTEL_TDX_HOST > > If unsure, say N. > > +config INTEL_TDX_MODULE_UPDATE > + bool "Intel TDX module runtime update" > + depends on INTEL_TDX_HOST > + help > + This enables the kernel to support TDX module runtime update. This allows > + the admin to upgrade the TDX module to a newer one without the need to > + terminate running TDX guests. > + > + If unsure, say N. > + WHy should this be conditional?