From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6543A3E5A32 for ; Wed, 9 Sep 2026 07:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788938178; cv=none; b=JMyp1BADx/bfsEDSE5OSv/3dQG3Qkn5TebeVqo+tNLK3JirO1+pN3czEJ69qM5vsQqBXHMMl7GGeeFdQaSK2XeYR+34XSHXc2p6qrJVMQ4TJN5cvLdiYvQqfpowUZfVK0cmD+ZcNFHlowSVXjq9Obmk9t4dsoLt4n59VHOoswaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788938178; c=relaxed/simple; bh=lNRh4Ug+0jrMIbREJmjMQuXJJOWFiwwwa8CKqxJCEBU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FqjVcoBziTH+6VJrnPwz63ZGUgyvVYJPfaVZH5VL7D84jAsX6pA3898Jtdip9x3sspuqicxDMUvYkYjh6Jxf64XRcAPzD4Ylv4m20jS+fGjOMtzPTL8hveeZ+xY5Y5bUXXWtBVTPklDG11ISCQjogw/p03H3Kd9HHPMKYlXXcXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OB2CAXm5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OB2CAXm5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788938172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3nSCBRaPtDIkAJm5QAiHh9cgImBPw7ThpI3/NAdqqvM=; b=OB2CAXm52VrvOKukRwZ2RVriqDyieslVzt8rWVrNxgaK6/8AAHgHI9G/wxy0R722xdu9J7 CCIrS2KqmP7zrFoOu5tWer3s0kEcR/41noDq7/2wCiq+xT/N8jaI6/cZWn57GjBqJ+O3Dj hpIQaCdD7uv5Y/0tFUNGcgHYQVuJTmE= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-RPbB7LBiPP6_xe4U6VA6sA-1; Wed, 09 Sep 2026 03:16:11 -0400 X-MC-Unique: RPbB7LBiPP6_xe4U6VA6sA-1 X-Mimecast-MFC-AGG-ID: RPbB7LBiPP6_xe4U6VA6sA_1788938170 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb48f41343aso5843242a12.1 for ; Wed, 09 Sep 2026 00:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788938170; x=1789542970; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3nSCBRaPtDIkAJm5QAiHh9cgImBPw7ThpI3/NAdqqvM=; b=Lugj1yXqOE6TaKxVqN4z4z/IC5KLy4LVYLnu6YgyteqqCz0KS8OQbVa+oEe78i8+SI awXJPbxVsEbdKmvwzvsfqU61PwOokwh1DES5HPwpHujxESxoJWbIWP6UM4+OdS9exsUb KmPARuYiI+zaE4s+m8DW+BYro0c8OesetQ+nk/Xufo3OIfMAlrFda/P7pIhMh70jpUzz JkcHQ6MZB1Mt95Iz10lEJBOdQPpeXxYnFJWedm3shNp1zBTDo6R9jC2OOzqZeKg/D6JF n60HcGQj6q6nNWR8K8YwjyOBIYnVaWOFUNcM2hxonS1339n/LnbEs8rBUNidTNfXFsA3 H12A== X-Forwarded-Encrypted: i=1; AKwUvBxHfblBWL7IZcVyBePKEtEQ3dCOxsjcbc6vOVUWsyi/KxOIG3Wtp4T5FENPWJHv8Kz5Zy6gTZRPEONC@lists.linux.dev X-Gm-Message-State: AFuF++mZdW2zX5b/ZOaTwOX93hPITpCFk4eJ7VOB4mGJTlvkeF8RvWBw 2n9kpKvhR1SdyfXnxZOPzfifjcB4klWL0gqZYEJBvrTOsRqITzSmbaDsIQhj3kqqrrEunSL+JvH gKQ3mJnAYb1ynrAJEt6YyE7758FUGsAfIqMJ/TO5thn0A2hsmW9GdNwvgpmhCfxw= X-Gm-Gg: AYBFou1p8f2940K1d8LlSEqMkM6EIIrsvY6hEQswawvG0YfPgE8GaLLf2YmSinJwpPk 21+jpFJPQBxlzbLCAyOuxDeSpFC+NQZxjaNxzvBm4YyAjsRyO6iYWKy2HJkMy7q23kbkorgnEm7 KjYEhXU63i+3aplCeKbufZb7FefxOa8Wpq+5Ag/W9ch7w5hrhBZMdch0Ney5Fb3F5iItUQyOQL8 VN8BU0db0nIWXIRRKF0fBVUpfKMqNptyyvVHKEl2jI6Xs1tghxtj7JP2lasotWp4VPQfdjnTvsp QorT9sUFx8+8zrl7n4s6hpdpleDkaTmS4VKxBxjKw3suX5sJVw+i/BphQMmQ51r0xUl8x6T5lLg 0QvHehEzrk1wuO9w4fBCY6/vmCi0D/nkq7ZHboRdBhg== X-Received: by 2002:a17:90b:5743:b0:38e:c232:9d2c with SMTP id 98e67ed59e1d1-39b8bc9422emr8480328a91.2.1788938169581; Wed, 09 Sep 2026 00:16:09 -0700 (PDT) X-Received: by 2002:a17:90b:5743:b0:38e:c232:9d2c with SMTP id 98e67ed59e1d1-39b8bc9422emr8480293a91.2.1788938168914; Wed, 09 Sep 2026 00:16:08 -0700 (PDT) Received: from [192.168.68.52] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d086adsm37441647a91.15.2026.09.09.00.15.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 00:16:08 -0700 (PDT) Message-ID: Date: Wed, 9 Sep 2026 17:15:56 +1000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 7/7] firmware: arm_rmm: Add wrappers for Realm related RMI commands To: Suzuki K Poulose , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: maz@kernel.org, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, aneesh.kumar@kernel.org, oupton@kernel.org, joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, sdonthineni@nvidia.com, alpergun@google.com, fj0570is@fujitsu.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org, enju.kohei@fujitsu.com References: <20260907095942.1140734-1-suzuki.poulose@arm.com> <20260907095942.1140734-8-suzuki.poulose@arm.com> From: Gavin Shan In-Reply-To: <20260907095942.1140734-8-suzuki.poulose@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: t0HfWQdQeHi8zwyIgmra277ZzVGXVNHg5dDFg_LB8Mc_1788938170 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/7/26 7:59 PM, Suzuki K Poulose wrote: > From: Steven Price > > Introduce wrappers for the RMI functions needed for creating and > managing realm guests. This will be used by the KVM to manage the > Realms > > Signed-off-by: Steven Price > Signed-off-by: Suzuki K Poulose > --- > Changes since v16: > * Split into a separate patch and move away from arch/arm64 to > include/linux/. > * Also moved into the firmware_rmm series from the KVM CCA support. > This is done in a hope to reduce the merge conflicts and make > the KVM CCA upstreaming in independent parallel chunks > --- > include/linux/arm-rmi-cmds.h | 453 +++++++++++++++++++++++++++++++++++ > 1 file changed, 453 insertions(+) > > diff --git a/include/linux/arm-rmi-cmds.h b/include/linux/arm-rmi-cmds.h > index 79e2c1f165112..746257d77dd61 100644 > --- a/include/linux/arm-rmi-cmds.h > +++ b/include/linux/arm-rmi-cmds.h > @@ -222,4 +222,457 @@ static inline long rmi_granule_range_undelegate(unsigned long base, > return ret; > } > > +/** > + * rmi_rtt_data_map_init() - Create a protected mapping with data contents ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ s/Create a protected mapping with data contents/Create a mappings in protected IPA with known contents With this, it's consistently counterpart of the comments for rmi_rtt_data_map(). > + * @rd: PA of the RD > + * @data: PA of the target granule > + * @ipa: IPA at which the granule will be mapped in the guest > + * @src: PA of the source granule > + * @flags: RMI_MEASURE_CONTENT if the contents should be measured > + * > + * Create a mapping from Protected IPA space to conventional memory, copying > + * contents from a Non-secure Granule provided by the caller. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_data_map_init(unsigned long rd, unsigned long data, > + unsigned long ipa, unsigned long src, > + unsigned long flags) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_DATA_MAP_INIT, rd, data, ipa, src, flags > + }; > + > + return rmi_sro_execute(®s); > +} > + > +/** > + * rmi_rtt_data_map() - Create mappings in protected IPA with unknown contents > + * @rd: PA of the RD > + * @base: Base of the target IPA range > + * @top: Top of the target IPA range > + * @flags: Flags > + * @oaddr: Output address set descriptor > + * @out_top: Top address of range which was processed. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_data_map(unsigned long rd, > + unsigned long base, > + unsigned long top, > + unsigned long flags, > + unsigned long oaddr, > + unsigned long *out_top) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_DATA_MAP, rd, base, top, flags, oaddr > + }; > + long ret; > + > + ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS && out_top) > + *out_top = regs.a1; > + > + return ret; > +} > + > +/** > + * rmi_rtt_data_unmap() - Remove mappings to conventional memory > + * @rd: PA of the RD for the target Realm > + * @base: Base of the target IPA range > + * @top: Top of the target IPA range > + * @flags: Flags > + * @oaddr: Output address set descriptor > + * @out_top: Returns top IPA of range which has been unmapped > + * @out_range: Output address range > + * @out_count: Number of entries in output address list > + * > + * Removes mappings to convention memory with a target Protected IPA range. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ It would be worthwhile to mention 'in protect IPA' where the mappings are teared down. Besides, 'for the target Realm' can be dropped from the comments for @rd. /** * rmi_rtt_data_unmap() - Remove mappings to conventional memory in protected IPA * @rd: PA of the RD * : */ > +static inline long rmi_rtt_data_unmap(unsigned long rd, > + unsigned long base, > + unsigned long top, > + unsigned long flags, > + unsigned long oaddr, > + unsigned long *out_top, > + unsigned long *out_range, > + unsigned long *out_count) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_DATA_UNMAP, rd, base, top, flags, oaddr > + }; > + long ret; > + > + ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS) { > + if (out_top) > + *out_top = regs.a1; > + if (out_range) > + *out_range = regs.a2; > + if (out_count) > + *out_count = regs.a3; > + } > + > + return ret; > +} The nested if statements can be avoided if we have: if (ret != RMI_SUCCESS) return ret; if (out_top) *out_top = regs.a1; if (out_range) *out_range = regs.a2; if (out_count) *out_count = regs.a3; return RMI_SUCCESS; > + > +/** > + * rmi_psci_complete() - Complete pending PSCI command > + * @calling_rec: PA of the calling REC > + * @status: Status of the PSCI request > + * > + * Completes a pending PSCI command. > + * > + * Return: RMI return code > + */ > +static inline long rmi_psci_complete(unsigned long calling_rec, > + unsigned long status) > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_invoke(SMC_RMI_PSCI_COMPLETE, calling_rec, status, &res); > + > + return res.a0; > +} > + > +/** > + * rmi_realm_activate() - Active a realm > + * @rd: PA of the RD > + * > + * Mark a realm as Active signalling that creation is complete and allowing ^^^^^^^^ s/complete/completed ? > + * execution of the realm. > + * > + * Return: RMI return code > + */ > +static inline long rmi_realm_activate(unsigned long rd) > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_invoke(SMC_RMI_REALM_ACTIVATE, rd, &res); > + > + return res.a0; > +} > + > +/** > + * rmi_realm_create() - Create a realm > + * @rd: PA of the RD > + * @params: PA of realm parameters > + * @sro: Preallocated SRO context to be used We needn't to have 'to be used. This comment applies to other helpers like rmi_realm_terminate(), rmi_realm_destroy(), rmi_rec_create(), rmi_rec_destroy() where a preallocated SRO context is needed. * @sro: Preallocated SRO context > + * > + * Create a new realm using the given parameters. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_realm_create(unsigned long rd, unsigned long params, > + struct rmi_sro_state *sro) > +{ > + return rmi_sro_memxfer_cmd(sro, GFP_KERNEL, > + SMC_RMI_REALM_CREATE, rd, params); > +} > + > +/** > + * rmi_realm_terminate() - Terminate a realm > + * @rd: PA of the RD > + * @sro: Preallocated SRO context to be used > + * > + * Terminates a realm, moving it into a ZOMBIE state > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_realm_terminate(unsigned long rd, > + struct rmi_sro_state *sro) > +{ > + return rmi_sro_memxfer_cmd(sro, GFP_KERNEL, > + SMC_RMI_REALM_TERMINATE, rd); > +} > + > +/** > + * rmi_realm_destroy() - Destroy a realm > + * @rd: PA of the RD > + * @sro: Preallocated SRO context to be used > + * > + * Destroys a realm, all objects belonging to the realm must be destroyed first. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_realm_destroy(unsigned long rd, > + struct rmi_sro_state *sro) > +{ > + return rmi_sro_memxfer_cmd(sro, GFP_KERNEL, > + SMC_RMI_REALM_DESTROY, rd); > +} > + > +/** > + * rmi_rec_create() - Create a REC > + * @rd: PA of the RD > + * @rec: PA of the target REC > + * @params: PA of REC parameters > + * @sro: Allocated SRO context to be used * @sro: Preallocated SRO context > + * > + * Create a REC using the parameters specified in the struct rec_params pointed > + * to by @params. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rec_create(unsigned long rd, > + unsigned long rec, > + unsigned long params, > + struct rmi_sro_state *sro) > +{ > + long ret; > + > + *sro = (struct rmi_sro_state){.regs = { > + SMC_RMI_REC_CREATE, rd, rec, params > + }}; > + ret = rmi_sro_memxfer_execute(sro, GFP_KERNEL); > + rmi_sro_free(sro); > + > + return ret; > +} > + > +/** > + * rmi_rec_destroy() - Destroy a REC > + * @rec: PA of the target REC > + * @sro: Allocated SRO context to be used * @sro: Preallocated SRO context > + * > + * Destroys a REC. The REC must not be running. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rec_destroy(unsigned long rec, > + struct rmi_sro_state *sro) > +{ > + return rmi_sro_memxfer_cmd(sro, GFP_KERNEL, SMC_RMI_REC_DESTROY, rec); > +} > + > +/** > + * rmi_rec_enter() - Enter a REC > + * @rec: PA of the target REC > + * @run_ptr: PA of RecRun structure > + * > + * Starts (or continues) execution within a REC. > + * > + * Return: RMI return code > + */ > +static inline long rmi_rec_enter(unsigned long rec, unsigned long run_ptr) > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_invoke(SMC_RMI_REC_ENTER, rec, run_ptr, &res); > + > + return res.a0; > +} > + > +/** > + * rmi_rtt_create() - Creates an RTT > + * @rd: PA of the RD > + * @rtt: PA of the target RTT > + * @ipa: Base of the IPA range described by the RTT > + * @level: Depth of the RTT within the tree > + * > + * Creates an RTT (Realm Translation Table) at the specified level for the > + * translation of the specified address within the realm. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_create(unsigned long rd, unsigned long rtt, > + unsigned long ipa, long level) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_CREATE, rd, rtt, ipa, level > + }; > + > + return rmi_sro_execute(®s); > +} > + > +/** > + * rmi_rtt_destroy() - Destroy an RTT > + * @rd: PA of the RD for the target realm * @rd: PA of the RD > + * @ipa: Base of the IPA range described by the RTT > + * @level: RTT level > + * @out_rtt: Pointer to write the PA of the RTT which was destroyed > + * @out_top: Pointer to write the top IPA of non-live RTT entries, from entry > + * at which the RTT walk terminated. > + * > + * Destroys an RTT. The RTT must be non-live, i.e. none of the entries in the > + * table are in ASSIGNED or TABLE state. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code. > + */ > +static inline long rmi_rtt_destroy(unsigned long rd, > + unsigned long ipa, > + long level, > + unsigned long *out_rtt, > + unsigned long *out_top) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_DESTROY, rd, ipa, level > + }; > + long ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS) { > + if (out_rtt) > + *out_rtt = regs.a1; > + if (out_top) > + *out_top = regs.a2; > + } > + > + return ret; > +} > + The nested if statements can be avoided if we have: if (ret != RMI_SUCCESS) return ret; if (out_rtt) *out_rtt = regs.a1; if (out_top) *out_top = regs.a2; return RMI_SUCCESS; > +/** > + * rmi_rtt_fold() - Fold an RTT > + * @rd: PA of the RD > + * @ipa: Base of the IPA range described by the RTT > + * @level: Depth of the RTT within the tree > + * @out_rtt: Pointer to write the PA of the RTT which was destroyed > + * > + * Folds an RTT. If all entries with the RTT are 'homogeneous' the RTT can be > + * folded into the parent and the RTT destroyed. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_fold(unsigned long rd, unsigned long ipa, > + long level, unsigned long *out_rtt) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_FOLD, rd, ipa, level > + }; > + long ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS && out_rtt) > + *out_rtt = regs.a1; > + > + return ret; > +} > + > +/** > + * rmi_rtt_init_ripas() - Set RIPAS for new realm > + * @rd: PA of the RD > + * @base: Base of target IPA region > + * @top: Top of target IPA region > + * @out_top: Top IPA of range whose RIPAS was modified > + * > + * Sets the RIPAS of a target IPA range to RAM, for a realm in the NEW state. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_init_ripas(unsigned long rd, unsigned long base, > + unsigned long top, unsigned long *out_top) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_INIT_RIPAS, rd, base, top > + }; > + long ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS && out_top) > + *out_top = regs.a1; > + > + return ret; > +} > + > +/** > + * rmi_rtt_unprot_map() - Map unprotected granules into a realm > + * @rd: PA of the RD > + * @base: Base IPA of the mapping > + * @top: Top of the target IPA range > + * @flags: Flags > + * @oaddr: Output address set descriptor > + * @out_top: Top IPA of range which has been mapped > + * > + * Create mappings to memory within a target unprotected IPA range. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_unprot_map(unsigned long rd, > + unsigned long base, > + unsigned long top, > + unsigned long flags, > + unsigned long oaddr, > + unsigned long *out_top) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_UNPROT_MAP, rd, base, top, flags, oaddr > + }; > + long ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS && out_top) > + *out_top = regs.a1; > + > + return ret; > +} > + > +/** > + * rmi_rtt_set_ripas() - Set RIPAS for an running realm > + * @rd: PA of the RD > + * @rec: PA of the REC making the request > + * @base: Base of target IPA region > + * @top: Top of target IPA region > + * @out_top: Pointer to write top IPA of range whose RIPAS was modified > + * > + * Completes a request made by the realm to change the RIPAS of a target IPA > + * range. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_set_ripas(unsigned long rd, unsigned long rec, > + unsigned long base, unsigned long top, > + unsigned long *out_top) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_SET_RIPAS, rd, rec, base, top > + }; > + long ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS && out_top) > + *out_top = regs.a1; > + > + return ret; > +} > + > +/** > + * rmi_rtt_unprot_unmap() - Remove mappings within an unprotected IPA range > + * @rd: PA of the RD > + * @base: Base IPA of the mapping > + * @top: Top of the target IPA range > + * @flags: Flags > + * @oaddr: Output address set descriptor > + * @out_top: Top IPA which has been unmapped > + * @out_range: Output address range > + * @out_count: Number of entries in output address list > + * > + * Removes mappings to memory within a target unprotected IPA range. > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rtt_unprot_unmap(unsigned long rd, > + unsigned long base, > + unsigned long top, > + unsigned long flags, > + unsigned long oaddr, > + unsigned long *out_top, > + unsigned long *out_range, > + unsigned long *out_count) > +{ > + struct arm_smccc_1_2_regs regs = { > + SMC_RMI_RTT_UNPROT_UNMAP, rd, base, top, flags, oaddr > + }; > + long ret = rmi_sro_execute(®s); > + > + if (ret == RMI_SUCCESS) { > + if (out_top) > + *out_top = regs.a1; > + if (out_range) > + *out_range = regs.a2; > + if (out_count) > + *out_count = regs.a3; > + } > + > + return ret; > +} > + The nested if statements can be avoided if we have: if (ret != RMI_SUCCESS) return ret; if (out_top) *out_top = regs.a1; if (out_range) *out_range = regs.a2; if (out_count) *out_count = regs.a3; return RMI_SUCCESS; > #endif Thanks, Gavin