From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EB353EA97A for ; Tue, 13 Oct 2026 10:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791887614; cv=none; b=cuGjJLPvQZB9y3VtXkWCKKrc/6Is7BA+cxNi9h7+p2jiE5NRXXBNflBj6eFe4fJDaV7OD7MmVEVrrrVQ2tLjJjOzLSyP8dRdwtLOuu50/Q8mZ+Lr8UxZS5CuT8A8+ldAP1/et9cTmJKAMDWb+lrON6JRwq2v0Hj8M2Is2ru1t9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791887614; c=relaxed/simple; bh=v/JLR1k7vDq5gemTKx0rWQ8eRukOJycBoxATbt53WRk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o4DN9FM4gRA/hegZmyiVcNAsbARN6QmOdu/JwmBOgvrAIpKdwonZwoyBWxIMWah8zpqv9BJn4GUtWh/mSphiLj+YtTzif5CAyivw6v74uwZ1L3h47gTMwWeV8M4NpN27vNdAnGEEZNMwGecWeBkDchMDZ3KINn/bV62/9as6JCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lAu/I+8T; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lAu/I+8T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791887613; x=1823423613; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=v/JLR1k7vDq5gemTKx0rWQ8eRukOJycBoxATbt53WRk=; b=lAu/I+8T2Z46LrUTwptpvQDoRXpKUR4PE0DzsRiz4+KigILihaDhsks6 BB4+HIOFtbrBgHixLXajsABGQMPvYLTMFXHVfQSAeYJ00doE0p54FANfs Ds0NqOSrG7fpGfjT5nD2k7XmwNet5L1c9kX2madIZsEJNxWRt8gCXzcEG 5+dBVM9wtfkt+RKojTnnD0swZsgTYwrN1zqicuwqNVMrMz8q7kXr1FAtV scN+VfUmGs3H4xqg7h2DfOF4qCFdNdglF8p6ySNVpGxIBwzdA0zHXbfB9 IlAyZgFUU70Lok8QWnuam5gf+AFcqIrLh1Ar8G6dygo85AieNTgpyjEGI w==; X-CSE-ConnectionGUID: WI1boBfeROCsiftIChi+zg== X-CSE-MsgGUID: T91NfVh3ScaLERZxMu4D3g== X-IronPort-AV: E=McAfee;i="6800,10657,11933"; a="504752" X-IronPort-AV: E=Sophos;i="6.27,155,1787036400"; d="scan'208";a="504752" Received: from fmviesa011.fm.intel.com ([10.60.135.151]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2026 03:33:33 -0700 X-CSE-ConnectionGUID: LuxTilyERgG79q6+TJlAKw== X-CSE-MsgGUID: 3KdVQ1pBSpu0IhMeeBwiGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,155,1787036400"; d="scan'208";a="2966398" Received: from unknown (HELO [10.238.2.98]) ([10.238.2.98]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2026 03:33:29 -0700 Message-ID: Date: Tue, 13 Oct 2026 18:33:27 +0800 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/10] x86/virt/tdx: Use early returns in get_tdx_sys_info() To: Chao Gao Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, yilun.xu@linux.intel.com, tony.lindgren@linux.intel.com, rick.p.edgecombe@intel.com, nik.borisov@suse.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kiryl Shutsemau References: <20261012094754.27702-1-chao.gao@intel.com> <20261012094754.27702-10-chao.gao@intel.com> Content-Language: en-US From: Binbin Wu In-Reply-To: <20261012094754.27702-10-chao.gao@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/12/2026 5:47 PM, Chao Gao wrote: > get_tdx_sys_info() was generated by a script. It chains its metadata reads > with: > > ret = ret ?: get_tdx_sys_info_foo(...); > > The function is maintained by hand now. Use conventional early returns > instead. > > Print the module version only after its metadata has been read > successfully. The "ret ?:" chain has no early exit, so the pr_info() after > the version read prints a partially read or all-zero version when that read > fails. That is harmless, but once every other read returns on error, a > print after a failed read would look like a bug. > > AI was used under supervision to review code and workshop logs. > > Signed-off-by: Chao Gao > Reviewed-by: Rick Edgecombe Reviewed-by: Binbin Wu