From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010024.outbound.protection.outlook.com [52.101.61.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D226E3DB323 for ; Tue, 16 Jun 2026 06:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.24 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589855; cv=fail; b=EYU7vsKfre+R82CxGUikoS41r+4q0nFQ+Nh5up+i5jNuv3rylV8eZ7Q8UfZ2KRW/KWjerGdXKaidJTCWha4oswxenbC+Bz5oPo9jiQHqH1CJeLgwZa3SA7oKL3y4CzJTTYCN7Ft4+zzL9x4ZsJOpEnNJJlqVk/D8iNkXib0Iq54= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589855; c=relaxed/simple; bh=mTgiDi1KF0DwB0HoQjxcIxygCu9t+Smi2caxnDJOhlY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=sA1Bx3cI4rRw81WWrsqx4CvlWse0PT/oqLTnJZgxgpdK6mMvT5MB9sooPuQOGTsR0XTPaG9eQXgtlTYKHkYbnEx2UJEXQTcEoZjqjyy3aRCuym1RAEVXo022Ig80puu7bow7t3zBI41n4YLmus8BOs9Hhy/mO1pPoBZ5hh9ANg4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=dqp0y49U; arc=fail smtp.client-ip=52.101.61.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="dqp0y49U" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E8yHNli2q9FcftlAUQ4xUu6kNzvGgNTLXh3h1wJJkBbSkkM+i45jJ81IVMCXw1VjMgnwYqVRVm/y33XVmrUVSe0v5zQO+2R0KAXtIQRLxY4RArhXl728XF985AeR1xggEHWyY77kiSflm2hsXXwTNMkE0ga3P08TSlmaL3ev7nJeJ6u6VtwOS3nbWhCDCSXdLjUKc26shZTK1QlAJx9KWZnmNFkGDmE+3EUrrjEVXPlxtPe/e8UCSiWtKMuJytXk0TGmjjos6MHrBEgCzDg59R76Ln6ziScEubm+EUMFzyAMiWV3Sdlbz+7DFgIAS38ST98abpBdCDWu0us2HBuJXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vlCqWAloRLHmBD57Evhm4kk0nDTP2qMQSPDNks/WIzA=; b=EhEeKJo6QHyctOiCABGk+EROCMoJc3ix9C0MUpuy6RUmLyGrNau5KNW0d4xrbBpbQm3lI1+9fRY8tNPpWy5/N4DlKOcPjWYxRY79J5GKktN9ddGvf4tMmvPGy536X0fQ3EdYwMFBaroO4y3kubZZalK/KrlUPHWmBlfosKaK7XijQugAcuaSVz6QTOm9MtXpWISWvOvwgHds+CH6TNK9R394sJpDALjFVRFUpZ9Mmua9TAwaiFhWeDpWvMcmhvlz2kKiyq7glkXwOojMsV/BbgG11ExXClQJRqZMGiy/Lk43xLkhLg5X3QsDkKilGfn1XKWIMgOFeGZPLJl+AIo1tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vlCqWAloRLHmBD57Evhm4kk0nDTP2qMQSPDNks/WIzA=; b=dqp0y49UnO6VX+8VKd521Tta6UrZKJCbreZCc5FkDiyBy1oejs6fj2mepy3mrgQhgOjer9o21+RPLOU6LcYBey7snwxN6ps9QQsKELclCJKe8CYqqKd/Zqg50HSxu391Uwz+kngRHMlVmWW22kvhajdAvu4FrcfusR+OycEEGK8= Received: from IA1P220CA0011.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:461::12) by DM4PR12MB8521.namprd12.prod.outlook.com (2603:10b6:8:17e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.18; Tue, 16 Jun 2026 06:04:07 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:208:461:cafe::9b) by IA1P220CA0011.outlook.office365.com (2603:10b6:208:461::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.113.18 via Frontend Transport; Tue, 16 Jun 2026 06:04:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Tue, 16 Jun 2026 06:04:07 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Tue, 16 Jun 2026 01:04:04 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Tue, 16 Jun 2026 01:04:01 -0500 Received: from [10.136.46.240] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Tue, 16 Jun 2026 01:03:52 -0500 Message-ID: Date: Tue, 16 Jun 2026 11:33:51 +0530 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/7] x86/sev: Initialize RMPOPT configuration MSRs To: Ashish Kalra , , , , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , References: <6a4d0ec9e037d91c0fdba9c525942ca288e1b1b2.1781419998.git.ashish.kalra@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <6a4d0ec9e037d91c0fdba9c525942ca288e1b1b2.1781419998.git.ashish.kalra@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|DM4PR12MB8521:EE_ X-MS-Office365-Filtering-Correlation-Id: 053f0527-cd57-4314-900d-08decb6d136e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700016|7416014|23010399003|376014|18002099003|22082099003|921020|56012099006|4143699003|11063799006; X-Microsoft-Antispam-Message-Info: siPdaCV4olqjDE/qkbDYXOZcY6otKFzrFgiSZOelGdI4nF/n8xhzCQBeZxWT/iMd7DEPdpNo9C+k1EKr5R/W2d//pKvtX13PsGuWY0WdvP+XSZw632m63KarJZBnZCP6L+BD9ObW3zK4tHqosFdwo6159I1fVx2mPJzIyc8KHszmUZsB83IsuRkMt3sQJyqrHxCoAvemtkMmNysi82QmkMZZ1n6UBBNYNZO4rS0Tl4eeZtxDRaPw3101xYOY+iWgmMrhkNdJeTptxkn9se4TWWurjtFi+mmH0jkalg30G82ykKqmUBwHo6faomvws9dsFS0UDeZkiWaQkSa7e6xvZRAq7qdVTxgCnAep3HIXkJ+a4Ca4h+gXOP6qtUjw2QXRsjYWuiykBYgF5a00NFYdNlL/qGGq+PvY7W9VVegW+ziW2Cxa6/2I+Y2diSA+BF2F4xULWBkbOGMMbKx4mIX/DEy2Hwp5/fIjaVHcSVEWCBvHlCXV+FoM+mmF+0UPGiLL8fgflcLORzx2kuzBOkizd/QU+gRXl/8WtuPVxINZhe0EoFJrLkusxOCyU5GJKwcSCr02ChrnP0k3pfvqHtvjSOVWL+nh5skLOPkbs6yU5Dh1D92+VNnuZFFiLK/0ds9AIBS8yuZ/S4JZnV0Mgb1lgTl2y7LYdI7C2hvD2dLF4PEHzCibJUgHzBpoa3+E+orw+sjx0KpSi7JOa/vkh3pdAfAY+u25mOPs5+8ytHCBvTdskIhFgBn7AWWpcKTXzN0qmIsTpwbEK+SAYxzt1xKMOg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700016)(7416014)(23010399003)(376014)(18002099003)(22082099003)(921020)(56012099006)(4143699003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: chl6PWOJ0V3OQG3cm0xJx9CrDm5jvItT3XgxKlbOfE8m0m+TQ08CnDGgskrxMzL8H5xRp1VeZ3pq+TIEKtooXx3I062jHnJT3Wkms3+aIUPsgu85qAL11LV+Vefy3iMTKLz5U+twvkXRaS1jfg/Zwh8eJ+xLIRLFs9vk8cJpJDxswTDtDzlamf8HwfQDAnyqv0qBntXMkvveUuY/2zCscRvKMB1j6pDxtZ9QBMtzvYSaaisHxaJpHJ54/5dhuXGp4c0LugIQqxN1bkdLOx8bcdi3GuP1eO+JlG6a8xst5e9Dg1SWywdYNciWvzIuCHmY2ae6yxGDBrA5/b38YsF1ir7UN4URJp5fR3i4/homXis5NffAwo1h5jmHZbBG2RFuucD4M4KyJw4+/iqOreuPtPwhq3RzhR6ejd4Kq9fL0v4bpmjqFhGGKCn0j04lZsc+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2026 06:04:07.0806 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 053f0527-cd57-4314-900d-08decb6d136e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8521 Hello Ashish, On 6/16/2026 1:18 AM, Ashish Kalra wrote: > diff --git a/arch/x86/virt/svm/sev.c b/arch/x86/virt/svm/sev.c > index 8bcdce98f6dc..1b5c18408f0b 100644 > --- a/arch/x86/virt/svm/sev.c > +++ b/arch/x86/virt/svm/sev.c > @@ -124,6 +124,10 @@ static void *rmp_bookkeeping __ro_after_init; > > static u64 probed_rmp_base, probed_rmp_size; > > +static cpumask_t rmpopt_cpumask; nit. I believe you can use cpumask_var_t here and do a zalloc_cpumask_var() during snp_setup_rmpopt(). That way !X86_FEATURE_RMPOPT configs don't have to needlessly waste space to keep a redundant cpumask around. Same comment for rmpopt_report_cpumask in Patch 7 which can be allocated dynamically during rmpopt_debugfs_setup(). > +static phys_addr_t rmpopt_pa_start; > +static bool rmpopt_configured; > + > static LIST_HEAD(snp_leaked_pages_list); > static DEFINE_SPINLOCK(snp_leaked_pages_list_lock); > > @@ -490,7 +494,12 @@ static bool __init setup_rmptable(void) > if (rmp_cfg & MSR_AMD64_SEG_RMP_ENABLED) { > if (!setup_segmented_rmptable()) > return false; > + rmpopt_configured = true; > } else { > + /* > + * RMPOPT requires a segmented RMP table, so leave > + * rmpopt_configured clear on contiguous RMP systems. > + */ > if (!setup_contiguous_rmptable()) > return false; > } > @@ -555,6 +564,21 @@ int snp_prepare(void) > } > EXPORT_SYMBOL_FOR_MODULES(snp_prepare, "ccp"); > > +static void rmpopt_cleanup(void) > +{ > + int cpu; > + > + cpus_read_lock(); nit. You can use guard(cpus_read_lock)() unless there is a complicated locking pattern where you need to drop and re-acquire the read lock. > + > + for_each_cpu(cpu, &rmpopt_cpumask) > + WARN_ON_ONCE(wrmsrq_on_cpu(cpu, MSR_AMD64_RMPOPT_BASE, 0)); > + > + cpus_read_unlock(); > + > + cpumask_clear(&rmpopt_cpumask); > + rmpopt_pa_start = 0; > +} > + > void snp_shutdown(void) > { > u64 syscfg; -- Thanks and Regards, Prateek