encapulating a find function in a script

encapulating a find function in a script

[BobGian]

> I'm having a problem with a simple script I'm trying to develop.
>
> Its name is fgrep and its text is:
>
>         #!/bin/bash
>         find $1 -name $2 -exec grep -H $3 '{}' ';'
>
> I want to use it like "dgrep 'directory' 'file pattern' 'match text'.
>
> It doesn't match anything because of the $2 parameter.  If I replace
> "$2" with "*.cpp", it works.
>
> Can anybody tell me what is wrong and how to fix it?

Try putting double-quotes around the parameters, like:

	 find $1 -name "$2" -exec grep -H "$3" '{}' ';'

This works for me in a similar script, at least in the csh shell.

 -Bob Giansiracusa

Re: encapulating a find function in a script

[Mike Castle]

On Wed, Jan 14, 2004 at 04:34:01PM -0800, BobGian@U.Washington.edu wrote:
> Try putting double-quotes around the parameters, like:
> 
> 	 find $1 -name "$2" -exec grep -H "$3" '{}' ';'
> 
> This works for me in a similar script, at least in the csh shell.

You may also find that using xargs instead of -exec is much faster (fewer
fork/execs).

Something like:

find "$1" -name "$2" -print0 | xargs -0 grep -H "$3"

mrc
-- 
     Mike Castle      dalgoda@ix.netcom.com      www.netcom.com/~dalgoda/
    We are all of us living in the shadow of Manhattan.  -- Watchmen
fatal ("You are in a maze of twisty compiler features, all different"); -- gcc

Re: encapulating a find function in a script

[Jeffrey Holle]

No joy.
The problem appears to be the '*' character.
If I substitute an actual cpp filename, the script works.  However it 
not very useful this way.

BobGian@U.Washington.edu wrote:
>>I'm having a problem with a simple script I'm trying to develop.
>>
>>Its name is fgrep and its text is:
>>
>>        #!/bin/bash
>>        find $1 -name $2 -exec grep -H $3 '{}' ';'
>>
>>I want to use it like "dgrep 'directory' 'file pattern' 'match text'.
>>
>>It doesn't match anything because of the $2 parameter.  If I replace
>>"$2" with "*.cpp", it works.
>>
>>Can anybody tell me what is wrong and how to fix it?
> 
> 
> Try putting double-quotes around the parameters, like:
> 
> 	 find $1 -name "$2" -exec grep -H "$3" '{}' ';'
> 
> This works for me in a similar script, at least in the csh shell.
> 
>  -Bob Giansiracusa
> -
> To unsubscribe from this list: send the line "unsubscribe linux-console" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: encapulating a find function in a script

[Jeffrey Holle]

Got both original script and the suggested speed enhanced script to work 
by putting a double double quote around the second parameter reference, 
like ""$2"".
This was necessary to allow this parameter to be something like "*.cpp".
Without this treatment, *.cpp was expanded to the cpp files that 
happened to be in my current directory.
I'm using Mandrake 9.1 linux and employing the bash command shell.

Do other linux/unix oses have this strange behavior?

Jeffrey Holle wrote:
> No joy.
> The problem appears to be the '*' character.
> If I substitute an actual cpp filename, the script works.  However it 
> not very useful this way.
> 
> BobGian@U.Washington.edu wrote:
> 
>>> I'm having a problem with a simple script I'm trying to develop.
>>>
>>> Its name is fgrep and its text is:
>>>
>>>        #!/bin/bash
>>>        find $1 -name $2 -exec grep -H $3 '{}' ';'
>>>
>>> I want to use it like "dgrep 'directory' 'file pattern' 'match text'.
>>>
>>> It doesn't match anything because of the $2 parameter.  If I replace
>>> "$2" with "*.cpp", it works.
>>>
>>> Can anybody tell me what is wrong and how to fix it?
>>
>>
>>
>> Try putting double-quotes around the parameters, like:
>>
>>      find $1 -name "$2" -exec grep -H "$3" '{}' ';'
>>
>> This works for me in a similar script, at least in the csh shell.
>>
>>  -Bob Giansiracusa
>> -
>> To unsubscribe from this list: send the line "unsubscribe 
>> linux-console" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-console" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: encapulating a find function in a script

[BobGian]

> You may also find that using xargs instead of -exec is much faster
> (fewer fork/execs).
>
> Something like:
>
> find "$1" -name "$2" -print0 | xargs -0 grep -H "$3"
>
> mrc
> --

Thanks!  Tried it - works great.  Runs two or three times as fast
and with half as many page faults.

 -Bob

Re: encapulating a find function in a script

[Mike Castle]

On Fri, Jan 16, 2004 at 11:53:49AM -0800, BobGian@U.Washington.edu wrote:
> > You may also find that using xargs instead of -exec is much faster
> > (fewer fork/execs).
> >
> > Something like:
> >
> > find "$1" -name "$2" -print0 | xargs -0 grep -H "$3"
> >
> > mrc
> > --
> 
> Thanks!  Tried it - works great.  Runs two or three times as fast
> and with half as many page faults.

Just remember that the -print0 and -0 are GNU extensions.  If you work on
other OS's, you may need to look at going back to -exec, or see if they
offer any similar extensions.

mrc
-- 
     Mike Castle      dalgoda@ix.netcom.com      www.netcom.com/~dalgoda/
    We are all of us living in the shadow of Manhattan.  -- Watchmen
fatal ("You are in a maze of twisty compiler features, all different"); -- gcc

encapulating a find function in a script

[Jeffrey Holle]

I'm having a problem with a simple script I'm trying to develop.

Its name is fgrep and its text is:

	#!/bin/bash
	find $1 -name $2 -exec grep -H $3 '{}' ';'

I want to use it like "dgrep 'directory' 'file pattern' 'match text'.

It doesn't match anything because of the $2 parameter.  If I replace 
"$2" with "*.cpp", it works.

Can anybody tell me what is wrong and how to fix it?