From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82970325716 for ; Fri, 17 Apr 2026 09:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776417793; cv=none; b=Z9C5nXc56mD23+Koqapm73Aw38LehvyVnEeDjAzYyAjWIMwKsUGMY6IPysBxRKKhMaJ8hx9nMDJmyDZMXmtdJnDq5Tv0+RqwQ0eTKe9ru+hJYtaFTyXuUk1E+Vm09qingVFeaK1IvrBdNwAz0l77tBqsmaWshRc1WrYYq+rFr+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776417793; c=relaxed/simple; bh=2shIHeFcFKqjZ95jW4Vx29dUWa6l9PR8yAiG06v4dQ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rw6QpcDgZ5Bc3KsOUlAXo8AOLep52ql9D1+m13hE8l5whgBA4ga6CC8FpDMSkhdDxhLjhI8H+xU1lrjpF/DOBrGIhk1N7Zyo6/D166o4Mk+1SrHfwYMRAT4C4/GMmNiY7y/a/JSUuB6CPivpJgj9GojRT13KpLVPEuQenc9XDYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ha0enODd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J8THfom1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ha0enODd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J8THfom1" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H7afwi1872484 for ; Fri, 17 Apr 2026 09:23:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aDT6bG//biEbiFpAOOIJaupEFsvw4HKKTh0BeExEgow=; b=ha0enODd1FRFNQvH 6166uSBHHlQ0nJi5he1oiFTEZsjlZcRWF7Rvk5OHwwo7thjAK9B7ICrafS98w/4B sOwwGh37UpT0ddYuXc3qcZTIKFG/cz5jExiS3/iPIk2vMOpU8KocPKFMJ1QLd57P LFoOkfvJn1UeMozmBCFf6MNcQs6GNHjXeM5vijoYkW4tMAyRHB0uJmvmYo07w/W1 yGm2CAv1xjq7EbdzOzPlOOFjL2AczTlWJWqmU+kDxrKzLnZGkTwhsf/7atltpm/3 ZreONYAwUgZVDVhuDDVRf1MrLeiVlUbnO9me8ZYScsoVfV4HvuMPJsKQYQ4fKrhQ u9SvBg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dk2knbat8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 09:23:11 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35da99b90f6so729955a91.1 for ; Fri, 17 Apr 2026 02:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776417790; x=1777022590; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aDT6bG//biEbiFpAOOIJaupEFsvw4HKKTh0BeExEgow=; b=J8THfom1FFwJZJRaTMg57hk8jxYLjInIhd0pt/p+WlZwe2aCxZDCmH83K8BslILMBg 07g3EJHxY7YfQzW/reOgEh2esGQ9UWCsruyxNsz5DDumM5PuuhKrLV4VhyCosLLgYBmr 8PkRzBUU6jAzc0vn/GoipadUTqB5h70vD1mX8zMQubyefaU0QFzyWALBrrUm3A3KihoF 4txcC64oZEgCMNi9ZdoEsqGap8jEjB5BOL72GEU5ollt/AG3r9KA0jaUdQca78En3I+e MlEHeqlT7rU+meNZV/HLTccUN6XGktOF5wSJIU/y3JcWekvJ9rbpqQHzzkr91HWJlQZd XLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776417790; x=1777022590; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aDT6bG//biEbiFpAOOIJaupEFsvw4HKKTh0BeExEgow=; b=iDD3LHfVmLgUI/886uq2UPX9aKeDqTqCN6qQDVPoPSGXKQljt0YPVRjB4tYclkxl+S aUVvGD6KZIRhPU8Bm9uq1mDY3QAKUi4XHKrQXM0as9jwA0PG+0SoQoJHfZMQGMqsPrCA naprJLj1HZ6oIdOe6VsLHAavv9FZdzxPwZt1wExcJcJj4JGtElfKDDInPccqSOJOKWdd bwKFVISBbjaX4aE1D37t9U8GJDcjxQVIYQTi1KECFT41ENnXduYshwlSVGzkgd5mKdEZ TPqjnUVmmZ2XKj8dkvUIkgVYqjTCOidyfCGXgBjoeJmJoJ1ZblrcBn/4tzQl1Vq8mh7f 6ybg== X-Forwarded-Encrypted: i=1; AFNElJ9xE7Tc0BdncHnXIGysigitpJHuIx6TvmoMT0GO3p+KUwN4lANoSXbX1ieEceCLNqF7SLCCvR4HekN1S1U=@vger.kernel.org X-Gm-Message-State: AOJu0YzQUBezcwbVY4TqyjvpXB9CqfSB2DcZkE8SAXj0X9BTrBCdsx8g Eq3Ft3LGqH6WHy6K99cmZ1u+kct/0XMEgCTcrEszacdByVDFcBEt6KGZDp4AzBuUa+5b1n8dMzh HkSqLelIfA9Cu6b6Bd5oeJQzxxprweiChaaFlTXk94vOmUemQdeNf5gAv/HKk1z1tDBg= X-Gm-Gg: AeBDievBtew4lEfmLUUBZvp3FkenVmdBdls4aziTO5kvvubTcAXBU/ADtubS+0jaC0J rW/WSxBZv04bLdAoDRM6EK6FzBzFPx1aZoehbkRNVCzhg0+mxq6nrLkn4RJZ4xLji/lyiCHy3vT bjAnG7PNeHmP1xxK/kQLUcm5fWOC4mOVxjzDa+aAFZQ+NSjZoky5/VsRh4V0OBu+Iz00jbbrUsT QT+R/ncoi4f81TeMy/pnFhz1xuozDY6NTiuP7Xp3D+CQm277oNMRJlSU9e3qDJU4mnGzPSFy5P4 7nicoA4mf8VTByDwpPYab+ZFrHjPyrxv6gVCutf1AQnAegSb5tHskymbr+FJOQyj4zCx+q19845 VXQl2wvZtxc3Q37tktmTarFxZt3eImCspDTJRBHFRwfHgiNxUmnfnRGzh9EHZWg== X-Received: by 2002:a17:90b:1846:b0:35f:c796:ca5f with SMTP id 98e67ed59e1d1-3614047a264mr2204567a91.19.1776417790402; Fri, 17 Apr 2026 02:23:10 -0700 (PDT) X-Received: by 2002:a17:90b:1846:b0:35f:c796:ca5f with SMTP id 98e67ed59e1d1-3614047a264mr2204538a91.19.1776417789920; Fri, 17 Apr 2026 02:23:09 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3613fba13a4sm568153a91.9.2026.04.17.02.23.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 02:23:09 -0700 (PDT) Message-ID: <030ff8b4-c553-4e3d-84fc-30ae8bb24aaf@oss.qualcomm.com> Date: Fri, 17 Apr 2026 14:53:04 +0530 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: glymur: add TRNG node To: Konrad Dybcio , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260416-glymur_trng_enablement-v1-0-60abcfd45403@oss.qualcomm.com> <20260416-glymur_trng_enablement-v1-2-60abcfd45403@oss.qualcomm.com> <28108ec6-2b06-4b63-8e41-fa75b7858acf@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: <28108ec6-2b06-4b63-8e41-fa75b7858acf@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 2YwPqyLZZxJ38n6VGNe-X5LUFGai2-pV X-Authority-Analysis: v=2.4 cv=XNoAjwhE c=1 sm=1 tr=0 ts=69e1fbff cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=V3ZMZ3GGzncCEMzdExUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 2YwPqyLZZxJ38n6VGNe-X5LUFGai2-pV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDA5MyBTYWx0ZWRfX9Iz7j1nK3fVv 4Sj3ae5eob2etODTVDEzYHJpSbz6yLUAb0KrjAvRmpIsWbn1RS2KYF4+GlYJApYH4GihdzaF+r+ VxqV+r2qxVCqSsExsfdQTh6FGHbNEat3xTy8JPF8y9tBpIVfLTfIFYPyWkiFB5SMGtdiIBzg8fx vogfzASfmLxkfwTl3huFV5dHG4kGPFoRzanEOVPmDCGf22m9NbixRQcQDXy/PlWvEJ/S0Z32R8R yk1nRn76LHvHNx3RGBU9WMVkAi2+prnDRJbDY5cf8DvhMvCm0OEKjz8m2zOsKIwt0H2DDmfWJWZ YtR13eCyzifFmrv31eQZppIySZkYoO1rjr5BB9qsMmYRrm8ATI8/QiM/71smPjoFdbAWjsRNMi+ F7XjWeje7hyNFrs2U2FF6Jnypre0Ers9qXaYpXGUknO3wVa9yhOBbKTZb7odZfWp4vD1I7bfPkh 45strJoqyokSzYX7lvA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170093 On 4/16/2026 6:03 PM, Konrad Dybcio wrote: > On 4/16/26 2:26 PM, Harshal Dev wrote: >> Glymur has a True Random Number Generator, add the node with the correct >> compatible set. >> >> Signed-off-by: Harshal Dev >> --- >> arch/arm64/boot/dts/qcom/glymur.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi >> index f23cf81ddb77..c9d46ec82ccc 100644 >> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi >> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi >> @@ -3675,6 +3675,11 @@ pcie3b_phy: phy@f10000 { >> status = "disabled"; >> }; >> >> + rng: rng@10c3000 { >> + compatible = "qcom,glymur-trng", "qcom,trng"; >> + reg = <0x0 0x10c3000 0x0 0x1000>; > > Please pad the address part to 8 hex digits with leading zeroes > Ack. Regards, Harshal > with that: > > Reviewed-by: Konrad Dybcio > > Konrad