Re: [PATCH v2 3/3] NFSD: Sign filehandles

[Chuck Lever <cel@kernel.org>]

On 1/26/26 1:22 PM, Benjamin Coddington wrote:
> On 24 Jan 2026, at 14:48, Chuck Lever wrote:
> 
>> I can't recall if Wireshark is smart enough to introspect Linux NFSD
>> file handles (I thought it could). It would be sensible to have some
>> Wireshark update code in hand before making the final decision about
>> keeping the new auth_type.
> 
> I've gone digging and wireshark has a surprising amount of filehandle
> dissection code - it currently can "Decode As:"
> 
> dissect_fhandle_data_SVR4
> dissect_fhandle_data_LINUX_KNFSD_LE
> dissect_fhandle_data_LINUX_NFSD_LE
> dissect_fhandle_data_NETAPP
> dissect_fhandle_data_NETAPP_V4
> dissect_fhandle_data_NETAPP_GX_v3
> dissect_fhandle_data_LINUX_KNFSD_NEW
> dissect_fhandle_data_GLUSTER
> dissect_fhandle_data_DCACHE
> dissect_fhandle_data_PRIMARY_DATA
> dissect_fhandle_data_CELERRA_VNX
> dissect_fhandle_data_unknown
> 
> .. almost all with finer grained filehandle components.  I certainly can add
> patches to parse FH_AT_MAC for the linux(s) decoders, but I admit I don't
> have any use case.
> 
> I'm completely neutral on keeping FH_AT_MAC at this point.

If we can't find a use case or need for something, the usual practice is
to remove it from your patches until we have one.

Is anyone working on Wireshark patches to handle signed Linux file
handles in some kind of sensible way?


-- 
Chuck Lever