From: Taehee Yoo <ap420073@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
kirill.shutemov@linux.intel.com, richard@nod.at,
viro@zeniv.linux.org.uk,
sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@kernel.org,
elliott@hpe.com, x86@kernel.org, jussi.kivilinna@iki.fi
Subject: Re: [PATCH v5 3/4] crypto: aria: implement aria-avx2
Date: Fri, 18 Nov 2022 19:45:13 +0900 [thread overview]
Message-ID: <07f353fd-1f36-2f58-63da-b15d3473ab40@gmail.com> (raw)
In-Reply-To: <Y3dK9hHXZSgpVdV1@sol.localdomain>
Hi Eric,
Thank you so much for your review!
On 11/18/22 18:05, Eric Biggers wrote:
> On Fri, Nov 18, 2022 at 07:22:51AM +0000, Taehee Yoo wrote:
>> +SYM_FUNC_START(aria_aesni_avx2_encrypt_32way)
>
> Please use SYM_TYPED_FUNC_START (and include <linux/cfi_types.h>) for all
> assembly functions that are called via indirect function calls.
Otherwise the
> code will crash when built with CONFIG_CFI_CLANG=y.
>
> - Eric
Okay, I will use SYM_TYPED_FUNC_START for avx2 and avx512 in the v6
patchset.
Thanks a lot!
Taehee Yoo
next prev parent reply other threads:[~2022-11-18 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 7:22 [PATCH v5 0/4] crypto: aria: implement aria-avx2 and aria-avx512 Taehee Yoo
2022-11-18 7:22 ` [PATCH v5 1/4] crypto: aria: add keystream array into request ctx Taehee Yoo
2022-11-18 7:22 ` [PATCH v5 2/4] crypto: aria: do not use magic number offsets of aria_ctx Taehee Yoo
2022-11-18 7:22 ` [PATCH v5 3/4] crypto: aria: implement aria-avx2 Taehee Yoo
2022-11-18 9:05 ` Eric Biggers
2022-11-18 10:45 ` Taehee Yoo [this message]
2022-11-18 7:22 ` [PATCH v5 4/4] crypto: aria: implement aria-avx512 Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f353fd-1f36-2f58-63da-b15d3473ab40@gmail.com \
--to=ap420073@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=elliott@hpe.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=jussi.kivilinna@iki.fi \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox