Re: [RFC][PATCH] crypto: caam - Add missing MODULE_ALIAS

[Marek Vasut <marex@denx.de>]

On 9/16/21 3:59 PM, Krzysztof Kozlowski wrote:
> On 16/09/2021 15:41, Marek Vasut wrote:
>> Add MODULE_ALIAS for caam and caam_jr modules, so they can be auto-loaded.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>> Cc: Horia Geantă <horia.geanta@nxp.com>
>> Cc: Iuliana Prodan <iuliana.prodan@nxp.com>
>> Cc: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>   drivers/crypto/caam/ctrl.c | 1 +
>>   drivers/crypto/caam/jr.c   | 1 +
>>   2 files changed, 2 insertions(+)
>>
> 
> Since you marked it as RFC, let me share a comment - would be nice to
> see here explanation why do you need module alias.
> 
> Drivers usually do not need module alias to be auto-loaded, unless the
> subsystem/bus reports different alias than one used for binding. Since
> the CAAM can bind only via OF, I wonder what is really missing here. Is
> it a MFD child (it's one of cases this can happen)?

I noticed the CAAM is not being auto-loaded on boot, and then I noticed 
the MODULE_ALIAS fixes cropping up in the kernel log, but I couldn't 
find a good documentation for that MODULE_ALIAS. So I was hoping to get 
a feedback on it.