From: Lu Jialin <lujialin4@huawei.com>
To: Steffen Klassert <steffen.klassert@secunet.com>,
"Guozihua (Scott)" <guozihua@huawei.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
"David S . Miller" <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v2] crypto: Fix hungtask for PADATA_RESET
Date: Mon, 4 Sep 2023 14:58:36 +0800 [thread overview]
Message-ID: <0a324e7d-2edc-0dda-d902-087e90191525@huawei.com> (raw)
In-Reply-To: <ZPVtyXevpj4Fiduw@gauss3.secunet.de>
Thanks for your suggestion. I will update the patch and remove retry in v3.
On 2023/9/4 13:40, Steffen Klassert wrote:
> On Fri, Sep 01, 2023 at 10:28:08AM +0800, Guozihua (Scott) wrote:
>> On 2023/8/23 17:28, Herbert Xu wrote:
>>> On Wed, Aug 23, 2023 at 07:30:47AM +0000, Lu Jialin wrote:
>>>>
>>>> In order to resolve the problem, we retry at most 5 times when
>>>> padata_do_parallel return -EBUSY. For more than 5 times, we replace the
>>>> return err -EBUSY with -EAGAIN, which means parallel_data is changing, and
>>>> the caller should call it again.
>>>
>>> Steffen, should we retry this at all? Or should it just fail as it
>>> did before?
>>>
>>> Thanks,
>>
>> It should be fine if we don't retry and just fail with -EAGAIN and let
>> caller handles it. It should not break the meaning of the error code.
>
> Just failing without a retry should be ok.
>
prev parent reply other threads:[~2023-09-04 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 7:30 [PATCH v2] crypto: Fix hungtask for PADATA_RESET Lu Jialin
2023-08-23 9:28 ` Herbert Xu
2023-09-01 2:28 ` Guozihua (Scott)
2023-09-04 5:40 ` Steffen Klassert
2023-09-04 6:58 ` Lu Jialin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a324e7d-2edc-0dda-d902-087e90191525@huawei.com \
--to=lujialin4@huawei.com \
--cc=daniel.m.jordan@oracle.com \
--cc=davem@davemloft.net \
--cc=guozihua@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox