Linux cryptographic layer development
 help / color / mirror / Atom feed
From: "Guozihua (Scott)" <guozihua@huawei.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <catalin.marinas@arm.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<zengxianjun3@huawei.com>, <yunjia.wang@huawei.com>
Subject: Re: An inquire about a read out-of-bound found in poly1305-neon
Date: Tue, 12 Jul 2022 09:57:50 +0800	[thread overview]
Message-ID: <107b496c-8106-b262-2731-444bd5e6e6d6@huawei.com> (raw)
In-Reply-To: <YsxksSnCsk3TQVD+@gmail.com>

On 2022/7/12 1:58, Eric Biggers wrote:
> On Mon, Jul 11, 2022 at 09:34:49PM +0800, Guozihua (Scott) wrote:
>> Directly calling poly1305_init_arm64 instead of poly1305_init_arch() is also
>> tried but it would fail the self-test as well.
> 
> I think that's the correct fix.  Are you sure it fails the self-test?  It should
> look like:
> 
> 	poly1305_init_arm64(&dctx->h, src);
> 
> Just like the arm32 version in arch/arm/crypto/poly1305-glue.c.  Note that
> &dctx->h must be used rather than just dctx.
> 
> - Eric
> .

Thanks Eric, I'll have a try!

-- 
Best
GUO Zihua

      reply	other threads:[~2022-07-12  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 13:34 An inquire about a read out-of-bound found in poly1305-neon Guozihua (Scott)
2022-07-11 17:58 ` Eric Biggers
2022-07-12  1:57   ` Guozihua (Scott) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=107b496c-8106-b262-2731-444bd5e6e6d6@huawei.com \
    --to=guozihua@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=yunjia.wang@huawei.com \
    --cc=zengxianjun3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox