Re: [PATCH v3] Jitter RNG - Permanent and Intermittent health errors

["Stephan Müller" <smueller@chronox.de>]

Am Samstag, 25. März 2023, 15:44:59 CEST schrieb Vladis Dronov:

Hi Vladis,

> Hi, Stephan,
> 
> On Fri, Mar 24, 2023 at 6:56 PM Stephan Mueller <smueller@chronox.de> wrote:
> > Thank you very much. I have fixed it in my local copy, but will wait for
> > another bit in case there are other reports.
> 
> A couple of more suggestions, if I may. These are really small,
> I'm suggesting them just due to a sense of perfection.
> 
> 1) A patch name. All the patches in this area look like
> "crypto: jitter - <lowercase letters>". Probably a patch name could be
> adjusted as "crypto: jitter - permanent and intermittent health errors"?

Will do.
> 
> 2) You use panic("Jitter RNG permanent health test failure\n") in your
> patch. With that, probably, jent_panic() could be removed, since
> nothing is using it, couldn't it?

Yes, you are right. I will remove it.
> 
> Best regards,
> Vladis


Thanks a lot
Stephan