From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405F9C4332F for ; Thu, 3 Nov 2022 13:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230336AbiKCNcF (ORCPT ); Thu, 3 Nov 2022 09:32:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbiKCNcE (ORCPT ); Thu, 3 Nov 2022 09:32:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D6C4635D for ; Thu, 3 Nov 2022 06:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667482261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J1pwMoixehBB6/exsa/xgFUL6PKhjwpqvEeah5GcAlk=; b=iW0/jonnrA7eMEqBDQoyYwSsrkFEq4zl/NXrt5KjMqqy66O/6H4OyZ0jYPaVo/ATeesOVn OvM37oA2HewMB/lAL38LvJIVIgKyUiyoLn7HS+S9ZRisvNvXg5lwpQ0d4of7yyWd9aMCB5 0rAjvahaJzrSgpaMvULBDucT4iVuo4g= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-262-pzzDIXDSP36GwyunJ4gSgA-1; Thu, 03 Nov 2022 09:31:00 -0400 X-MC-Unique: pzzDIXDSP36GwyunJ4gSgA-1 Received: by mail-ej1-f72.google.com with SMTP id oz34-20020a1709077da200b007adc8d68e90so1263606ejc.11 for ; Thu, 03 Nov 2022 06:30:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J1pwMoixehBB6/exsa/xgFUL6PKhjwpqvEeah5GcAlk=; b=djCsnMzU1DqnSvbwdrBNZSlHVdypmrkwAV5niVi7rxh6pP3c/5sDx05cGCKjDbYQiZ 1kAhti1RGOGxfRzBtKEt+IOqOUy6JQfXQY6qVjDCmAxAlnxyFyHHAXXL+ntWOPelAdVs gDGpws5TyHA9H/bsFPRb6nZNj34yv0cNnu/hKns6bDnMTtUAY6oJdxbaoaxB1JqLrvyE 8oUypdrR4rCrlDFfN8pnKOycv3nuuVARDZstvfc1t1JrxVVLBoEIRbo1w7M4Nz19BmfE RQBUiuQoZjBlU8Ww4oMB8dUGRhIl7/CsSdqBMRvh2WpvMU4tT8+N7Ca87N+dRl2xXYL7 BELg== X-Gm-Message-State: ACrzQf3LCNeuYGNCnwsJXs9P+ezXKnkDnnkh2SrzoG96mBPWyoCIxLRQ aN1pxNT9HIGTVv+7V0CQxV+lVsfwhuIiZXIb03jQUKnNqD/HTxyP3GKOkitkMIgC+4gHbEaTeqT SjYjNngweSmy195Yr+x95Ymv+ X-Received: by 2002:aa7:da0a:0:b0:461:135e:7298 with SMTP id r10-20020aa7da0a000000b00461135e7298mr29826261eds.242.1667482259081; Thu, 03 Nov 2022 06:30:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4uP66wYjZQz+zFm2TRRot723nL19VWlEAfPOzWcUzZlqhtnavJOZFU4zZK5IHLVc6ZLRkUpw== X-Received: by 2002:aa7:da0a:0:b0:461:135e:7298 with SMTP id r10-20020aa7da0a000000b00461135e7298mr29826243eds.242.1667482258880; Thu, 03 Nov 2022 06:30:58 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:1c09:f536:3de6:228c? ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.googlemail.com with ESMTPSA id g16-20020a170906539000b007ad98918743sm513858ejo.1.2022.11.03.06.30.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 06:30:58 -0700 (PDT) Message-ID: <122e2dc2-743a-0518-c910-fdf5ced328e3@redhat.com> Date: Thu, 3 Nov 2022 14:30:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 1/5] perf/x86/intel/lbr: use setup_clear_cpu_cap instead of clear_cpu_cap Content-Language: en-US To: "Elliott, Robert (Servers)" , Borislav Petkov , Maxim Levitsky Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Pawan Gupta , Ingo Molnar , Josh Poimboeuf , Namhyung Kim , Tony Luck , "H. Peter Anvin" , Arnaldo Carvalho de Melo , Thomas Gleixner , Alexander Shishkin , Tim Chen , "David S. Miller" , Dave Hansen , "Chang S. Bae" , Jane Malalane , Kees Cook , Kan Liang , Peter Zijlstra , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Herbert Xu , Jiri Olsa , Mark Rutland , "linux-perf-users@vger.kernel.org" , "open list:CRYPTO API" References: <20220718141123.136106-1-mlevitsk@redhat.com> <20220718141123.136106-2-mlevitsk@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 11/2/22 15:27, Elliott, Robert (Servers) wrote: > > 3. Similarly, modules using X86_FEATURE_XMM2 probably need to > check XFEATURE_MASK_SSE: > > Currently checking XSAVE SSE: > aegis128-aesni-glue > > Current not checking XSAVE SSE: > nhpoly1305-sse2_glue > serpent_sse2_glue These should check boot_cpu_has(X86_FEATURE_FXSR). Checking XFEATURE_MASK_SSE will fail on systems without XSAVE, because fpu_kernel_cfg.max_features is zero there (see fpu__init_system_xstate() in arch/x86/kernel/fpu/xstate.c). It happens to work for aegis128-aesni-glue because AES instructions only exist on new-enough parts, but it should probably be changed as well. Paolo