Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Jan Glauber <jang@linux.vnet.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Martin Schwidefksy <schwidefsky@de.ibm.com>
Subject: Re: crypto: sha-s390 - Switch to shash
Date: Mon, 02 Feb 2009 18:01:07 +0000	[thread overview]
Message-ID: <1233597667.1536.10.camel@localhost.localdomain> (raw)
In-Reply-To: <1233577246.18006.1.camel@localhost>

On Mon, 2009-02-02 at 13:20 +0100, Martin Schwidefsky wrote:
> On Wed, 2009-01-28 at 14:56 +1100, Herbert Xu wrote:
> > On Mon, Jan 19, 2009 at 09:55:17AM +1100, Herbert Xu wrote:
> > > 
> > > Could you let me if this patch breaks s390?
> > > 
> > > commit 0fe7dddf02811152d7e58747bfe419ec0f43ea4e
> > > Author: Herbert Xu <herbert@gondor.apana.org.au>
> > > Date:   Sun Jan 18 20:33:33 2009 +1100
> > > 
> > >     crypto: sha-s390 - Switch to shash
> > >     
> > >     This patch converts the S390 sha algorithms to the new shash interface.
> > >     
> > >     Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> > 
> > I'm going to throw this into cryptodev and if it breaks, please
> > yell.
> 
> Just back from my vacation. Jan will check if the patch breaks anything,
> we'll complain if it does..
> 

The patch is not yet in cryptodev, so I applied it on top of cryptodev.
Compiling it gives me the following error:

 CC [M]  arch/s390/crypto/sha256_s390.o
arch/s390/crypto/sha_common.c: In function ‘s390_sha_update’:
arch/s390/crypto/sha_common.c:23: error: implicit declaration of function ‘crypto_shash_blocksize’
make[1]: *** [arch/s390/crypto/sha_common.o] Error 1

--jan


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-02-02 17:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18 22:55 crypto: sha-s390 - Switch to shash Herbert Xu
2009-01-28  3:56 ` Herbert Xu
2009-02-02 12:20   ` Martin Schwidefsky
2009-02-02 18:01     ` Jan Glauber [this message]
2009-02-03  1:48       ` Herbert Xu
2009-02-03 15:16         ` Jan Glauber
2009-02-04  0:05           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233597667.1536.10.camel@localhost.localdomain \
    --to=jang@linux.vnet.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox