From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: crypto: return codes
Date: Sat, 09 Oct 2010 23:34:43 -0400 [thread overview]
Message-ID: <1286681683.2666.21.camel@localhost.localdomain> (raw)
In-Reply-To: <20101009012913.GA2829@gondor.apana.org.au>
On Sat, 2010-10-09 at 09:29 +0800, Herbert Xu wrote:
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > Hi,
> >
> > Looking at different examples of the same crypto call, it's unclear
> > whether it only returns negative error values. Some examples only test
> > for negative values, while others test for not 0. tcrypt.c does "if
> > (ret)". Would appreciate some clarification.
>
> Unless the call can return positive values then it makes no
> difference. Which particular call are you talking about?
>
> Cheers,
Just to name a few: crypto_hash_init(), crypto_hash_update(),
crypto_hash_final(). Also crypto_blkcipher_decrypt/encrypt(). Would be
nice to know definitively that they return < 0 on error and 0 for
success.
thanks!
Mimi
next prev parent reply other threads:[~2010-10-10 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 20:04 crypto: return codes Mimi Zohar
2010-10-09 1:29 ` Herbert Xu
2010-10-10 3:34 ` Mimi Zohar [this message]
2010-10-10 6:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286681683.2666.21.camel@localhost.localdomain \
--to=zohar@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox