From: David Safford <safford@watson.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@linux-nfs.org,
linux-crypto@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
James Morris <jmorris@namei.org>,
Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
Mimi Zohar <zohar@watson.ibm.com>
Subject: Re: [PATCH v1.4 3/5] key: add tpm_send command
Date: Fri, 19 Nov 2010 11:04:56 -0500 [thread overview]
Message-ID: <1290182696.2597.18.camel@localhost.localdomain> (raw)
In-Reply-To: <9837.1290181537@redhat.com>
On Fri, 2010-11-19 at 15:45 +0000, David Howells wrote:
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
>
> > +int tpm_send(u32 chip_num, void *cmd, int buflen)
>
> I'd recommend size_t for buflen; apart from that:
>
> Acked-by: David Howells <dhowells@redhat.com>
right - that would be better.
Currently transmit_command() in tpm.c expects an int,
but it changes it to size_t for the actual tpm_transmit().
We will work with Rajiv to do a cleanup, as this touches
a number of calls.
thanks!
dave
next prev parent reply other threads:[~2010-11-19 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 22:42 [PATCH v1.4 0/5] keys: trusted and encrypted keys Mimi Zohar
2010-11-18 22:42 ` [PATCH v1.4 1/5] lib: hex2bin converts ascii hexadecimal string to binary Mimi Zohar
2010-11-19 15:43 ` David Howells
2010-11-18 22:42 ` [PATCH v1.4 2/5] tpm: add module_put wrapper Mimi Zohar
2010-11-19 15:43 ` David Howells
2010-11-18 22:42 ` [PATCH v1.4 3/5] key: add tpm_send command Mimi Zohar
2010-11-19 15:45 ` David Howells
2010-11-19 16:04 ` David Safford [this message]
2010-11-19 16:45 ` David Howells
2010-11-18 22:42 ` [PATCH v1.4 4/5] keys: add new trusted key-type Mimi Zohar
2010-11-19 16:23 ` David Howells
2010-11-19 18:00 ` David Safford
2010-11-18 22:42 ` [PATCH v1.4 5/5] keys: add new key-type encrypted Mimi Zohar
2010-11-19 16:43 ` David Howells
2010-11-22 12:16 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290182696.2597.18.camel@localhost.localdomain \
--to=safford@watson.ibm.com \
--cc=dhowells@redhat.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=srajiv@linux.vnet.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
--cc=zohar@watson.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).