From: Jan Glauber <jang@linux.vnet.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto <linux-crypto@vger.kernel.org>
Subject: Re: crypto: sha1 - Add test vector to test partial block processing
Date: Fri, 18 Feb 2011 09:37:17 +0000 [thread overview]
Message-ID: <1298021837.17221.33.camel@bender> (raw)
In-Reply-To: <20110217205226.GA21423@gondor.apana.org.au>
On Fri, 2011-02-18 at 07:52 +1100, Herbert Xu wrote:
> On Thu, Feb 17, 2011 at 04:11:02PM +0100, Jan Glauber wrote:
> > Hi Herbert,
> >
> > good idea. I ended up with using openssl to create a test vector for
> > that special case but a published test vector is of course better.
> >
> > With your sha patch applied sha1_s390 survives the tcrypt test.
>
> Could you check if sha1_s390 fails the test without the patch?
Without 9d20b57 it gives:
[root@h4245005 ~]# modprobe tcrypt mode=2
FATAL: Error inserting tcrypt (/lib/modules/2.6.38-rc4-dirty/kernel/crypto/tcrypt.ko): Resource temporarily unavailable
[root@h4245005 ~]# tail -f /var/log/messages
...
Feb 18 10:22:13 h4245005 kernel: alg: hash: Chunking test 2 failed for sha1-s390
Feb 18 10:22:13 h4245005 kernel: 00000000: 4a d0 d6 bd 53 2b 6b df cd 34 b9 60 d1 90 85 d0
Feb 18 10:22:13 h4245005 kernel: 00000010: 38 70 2b 41
With the patch applied nothing shows up in dmesg.
--Jan
> Thanks!
next prev parent reply other threads:[~2011-02-18 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 9:28 crypto: sha-s390 - Reset index after processing partial block Herbert Xu
2011-02-07 12:47 ` Jan Glauber
2011-02-17 3:25 ` crypto: sha1 - Add test vector to test partial block processing Herbert Xu
2011-02-17 15:11 ` Jan Glauber
2011-02-17 20:52 ` Herbert Xu
2011-02-18 9:37 ` Jan Glauber [this message]
2011-02-18 9:43 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298021837.17221.33.camel@bender \
--to=jang@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox