From: Jan Glauber <jang@linux.vnet.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: Re: [PATCH 4/8] s390: add System z hardware support for CTR mode
Date: Wed, 27 Apr 2011 12:37:20 +0200 [thread overview]
Message-ID: <1303900640.3495.12.camel@localhost.localdomain> (raw)
In-Reply-To: <20110426063437.GA19539@gondor.apana.org.au>
On Tue, 2011-04-26 at 16:34 +1000, Herbert Xu wrote:
> On Tue, Apr 19, 2011 at 09:29:17PM +0200, jang@linux.vnet.ibm.com wrote:
> >
> > @@ -664,11 +784,6 @@ static int __init aes_s390_init(void)
> > if (ret)
> > goto cbc_aes_err;
> >
> > - /* skip XTS if MSA-4 is not available */
> > - if ((stfle(facility_bits, 2) <= 0) ||
> > - !(facility_bits[1] & (1ULL << (63 - (77 - 64)))))
> > - goto out;
>
> Any reason why this hunk is here?
This hunk is a left-over from development in the XTS patch and
superfluous so it should be removed. Should I repost the whole series?
Thanks, Jan
> Cheers,
next prev parent reply other threads:[~2011-04-27 10:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 19:29 [PATCH 0/8] (3rd take) add support for z196 CPACF algorithms jang
2011-04-19 19:29 ` [PATCH 1/8] s390: extend crypto facility check jang
2011-04-19 19:29 ` [PATCH 2/8] s390: cleanup DES code jang
2011-04-19 19:29 ` [PATCH 3/8] s390: add System z hardware support for XTS mode jang
2011-04-19 19:29 ` [PATCH 4/8] s390: add System z hardware support for CTR mode jang
2011-04-26 6:34 ` Herbert Xu
2011-04-27 10:37 ` Jan Glauber [this message]
2011-04-27 10:40 ` Herbert Xu
2011-05-04 5:10 ` Herbert Xu
2011-05-04 8:31 ` Jan Glauber
2011-04-19 19:29 ` [PATCH 5/8] s390: add System z hardware support for GHASH jang
2011-04-19 19:29 ` [PATCH 6/8] s390: cleanup s390 Kconfig options jang
2011-04-19 19:29 ` [PATCH 7/8] tcrypt: disable 384 bit key XTS test jang
2011-04-20 0:33 ` Herbert Xu
2011-04-20 15:19 ` Jan Glauber
2011-04-20 15:35 ` Herbert Xu
2011-04-19 19:29 ` [PATCH 8/8] tcrypt: CTR mode speed test for AES jang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303900640.3495.12.camel@localhost.localdomain \
--to=jang@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox