From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: msb@chromium.org, linux-kernel@vger.kernel.org,
herbert@gondor.hengli.com.au, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: sha1: modify sha1_update to use SHA1_BLOCK_SIZE
Date: Wed, 25 May 2011 20:52:01 -0700 [thread overview]
Message-ID: <1306381921.28839.17.camel@Joe-Laptop> (raw)
In-Reply-To: <20110525.233411.1372538972166578285.davem@davemloft.net>
On Wed, 2011-05-25 at 23:34 -0400, David Miller wrote:
> From: Mandeep Singh Baines <msb@chromium.org>
> Date: Wed, 25 May 2011 20:11:17 -0700
> > Plus some other minor cleanup.
> > Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> The temp[] buffer is explicitly places inside the inner most
> basic block so that the compiler doesn't allocate the stack
> space unless that code path is taken.
Does any version of gcc manage to do that?
Regardless, it's still a good idea to keep
declarations in the use scope.
next prev parent reply other threads:[~2011-05-26 3:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 3:11 [PATCH] crypto: sha1: modify sha1_update to use SHA1_BLOCK_SIZE Mandeep Singh Baines
2011-05-26 3:34 ` David Miller
2011-05-26 3:52 ` Joe Perches [this message]
2011-05-26 23:20 ` [PATCH v2] " Mandeep Singh Baines
2011-05-31 5:22 ` Herbert Xu
2011-06-23 19:02 ` [PATCH v3] crypto: sha1: " Mandeep Singh Baines
2011-06-27 7:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306381921.28839.17.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox