From: David Howells <dhowells@redhat.com>
To: Dmitry Kasatkin <d.kasatkin@samsung.com>
Cc: dhowells@redhat.com, zohar@linux.vnet.ibm.com,
linux-security-module@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.kasatkin@gmail.com
Subject: Making the asymmetric keys config option into a top-level option
Date: Thu, 17 Jul 2014 20:55:53 +0100 [thread overview]
Message-ID: <13161.1405626953@warthog.procyon.org.uk> (raw)
In-Reply-To: <acdd27e3b559b0c1bc57a9393e4e5540a90bab36.1405094060.git.d.kasatkin@samsung.com>
Dmitry Kasatkin <d.kasatkin@samsung.com> wrote:
> When ASYMMETRIC_KEYS=y, but depends on CRYPTO=m, selections will be also modules.
> In random config case OID_REGISTRY, MPILIB and ASN1 became modules producing build
> break. This patch removes asymmetric keys dependency from CRYPTO, but instead
> selects CRYPTO and CRYPTO_HASH as they are needed.
You do realise that this makes the asymmetric key config option into a
top-level option? I think, logically, that's the wrong thing to do. They
should still appear under the crypto menu.
Note that I think your patch is really the wrong solution. The right solution
is to fix the configuration tools - but that's quite an undertaking.
David
next prev parent reply other threads:[~2014-07-17 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 15:59 [PATCH 0/2] Fix build break on dependency from CRYPTO Dmitry Kasatkin
2014-07-11 15:59 ` [PATCH 1/2] asymmetric_keys: make crypto builtin if asymmetric keys selected as builtin Dmitry Kasatkin
2014-07-17 19:55 ` David Howells [this message]
2014-07-19 9:18 ` Making the asymmetric keys config option into a top-level option Dmitry Kasatkin
2014-07-11 15:59 ` [PATCH 2/2] digsig: make crypto builtin if digsig selected as builtin Dmitry Kasatkin
2014-07-17 19:56 ` David Howells
2014-07-19 8:50 ` Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13161.1405626953@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=d.kasatkin@samsung.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).