From: Joe Perches <joe@perches.com>
To: roel <roel.kluin@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-crypto <linux-crypto@vger.kernel.org>
Subject: drivers/media/video/s5p-fimc/fimc-capture.c: boolean and / or confusion
Date: Mon, 12 Dec 2011 15:55:23 -0800 [thread overview]
Message-ID: <1323734123.3837.2.camel@joe2Laptop> (raw)
In-Reply-To: <1323733493.1812.10.camel@joe2Laptop>
On Tue, 2011-12-13 at 00:06 +0100, roel wrote:
> The test not [val1] or not [val2] always evaluates to true
Hello
Looking at drivers with:
$ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers
drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width) {
drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width)
Most likely these tests should be:
if (mf->height != tfmt->height || mf->width != tfmt->width)
next prev parent reply other threads:[~2011-12-12 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4EE688FC.8090606@gmail.com>
2011-12-12 23:44 ` drivers/crypto/picoxcell_crypto.c: boolean and / or confusion Joe Perches
2011-12-12 23:55 ` Joe Perches [this message]
2011-12-13 14:26 ` drivers/media/video/s5p-fimc/fimc-capture.c: " Sylwester Nawrocki
2011-12-13 9:50 ` drivers/crypto/picoxcell_crypto.c: " Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323734123.3837.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=roel.kluin@gmail.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).