From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org, Jason@zx2c4.com,
herbert@gondor.apana.org.au, k.marinushkin@gmail.com,
linux-crypto@vger.kernel.org
Subject: Re: [RFC PATCH] KEYS: Use individual pages in big_key for crypto buffers
Date: Thu, 15 Feb 2018 21:36:01 +0000 [thread overview]
Message-ID: <13335.1518730561@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180215204528.GA49445@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> If big_key_alloc_buffer() fails to allocate one of the pages then some of
> the pages may still be NULL here, causing __free_page() to crash. You need
> to check for NULL first.
Ah, yes. I incorrectly used free_page() first - and that does check for a
NULL pointer. Applied your other changes also.
David
prev parent reply other threads:[~2018-02-15 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 15:54 [RFC PATCH] KEYS: Use individual pages in big_key for crypto buffers David Howells
2018-02-15 20:45 ` Eric Biggers
2018-02-15 21:36 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13335.1518730561@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Jason@zx2c4.com \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=k.marinushkin@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox