From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Chen Subject: Re: [PATCH v1] crypto: aesni - fix build on x86 (32bit) Date: Mon, 06 Jan 2014 10:10:55 -0800 Message-ID: <1389031855.2624.26.camel@schen9-DESK> References: <1388411544-4559-1-git-send-email-andriy.shevchenko@linux.intel.com> <1389030119.2624.19.camel@schen9-DESK> <637fa237-687f-4e88-88d2-4a9dd0c2bf14@email.android.com> <1389031023.2624.21.camel@schen9-DESK> <52CAEF55.5090308@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Andy Shevchenko , linux-crypto@vger.kernel.org, Herbert Xu , Borislav Petkov To: "H. Peter Anvin" Return-path: Received: from mga02.intel.com ([134.134.136.20]:17034 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755886AbaAFSKz (ORCPT ); Mon, 6 Jan 2014 13:10:55 -0500 In-Reply-To: <52CAEF55.5090308@zytor.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, 2014-01-06 at 10:00 -0800, H. Peter Anvin wrote: > On 01/06/2014 09:57 AM, Tim Chen wrote: > > On Mon, 2014-01-06 at 09:45 -0800, H. Peter Anvin wrote: > >> Can the code be adjusted to compile for 32 bit x86 or is that pointless? > >> > > > > Code was optimized for wide registers. So it is only meant for x86_64. > > > > Aren't the "wide registers" the vector registers? Or are you also > relying on 64-bit integer registers (in which case we should just rename > the file to make it clear it is x86-64 only.) > > -hpa > > Yes, the code is in the file named aesni_intel_avx.S. So it should be clear that the code is meant for x86_64. Tim