Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Harald Freudenberger <hfreude@linux.vnet.ibm.com>
To: Harald Freudenberger <freude@linux.vnet.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: s390 - fix concurrency issue in aes-ctr mode
Date: Tue, 21 Jan 2014 16:04:42 +0100	[thread overview]
Message-ID: <1390316682.25689.2.camel@Ubuntu12> (raw)
In-Reply-To: <1389884471-24964-1-git-send-email-freude@linux.vnet.ibm.com>

On Thu, 2014-01-16 at 16:01 +0100, Harald Freudenberger wrote:

> The aes-ctr mode uses one preallocated page without any concurrency
> protection. When multiple threads run aes-ctr encryption or decryption
> this can lead to data corruption.
> 
> The patch introduces locking for the page and a fallback solution with
> slower en/decryption performance in concurrency situations.
> 
> Signed-off-by: Harald Freudenberger <freude@linux.vnet.ibm.com>
> ---
>  arch/s390/crypto/aes_s390.c |   65 ++++++++++++++++++++++++++++++-------------
>  1 file changed, 46 insertions(+), 19 deletions(-)

Herbert, could you please add Cc: stable@vger.kernel.org to this?

Thanks

      reply	other threads:[~2014-01-21 15:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 15:01 [PATCH] crypto: s390 - fix concurrency issue in aes-ctr mode Harald Freudenberger
2014-01-21 15:04 ` Harald Freudenberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390316682.25689.2.camel@Ubuntu12 \
    --to=hfreude@linux.vnet.ibm.com \
    --cc=freude@linux.vnet.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox