From: chandramouli narayanan <mouli@linux.intel.com>
To: Marek Vasut <marex@denx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"H. Peter Anvin" <hpa@zytor.com>,
"David S.Miller" <davem@davemloft.net>,
Ilya Albrekht <ilya.albrekht@intel.com>,
Maxim Locktyukhin <maxim.locktyukhin@intel.com>,
Ronen Zohar <ronen.zohar@intel.com>,
Wajdi Feghali <wajdi.k.feghali@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v6 1/1] crypto: SHA1 transform x86_64 AVX2
Date: Thu, 20 Mar 2014 15:51:01 -0700 [thread overview]
Message-ID: <1395355861.2367.57.camel@pegasus.jf.intel.com> (raw)
In-Reply-To: <201403202324.17029.marex@denx.de>
On Thu, 2014-03-20 at 23:24 +0100, Marek Vasut wrote:
> On Thursday, March 20, 2014 at 11:14:00 PM, chandramouli narayanan wrote:
> > This git patch adds x86_64 AVX2 optimization of SHA1
> > transform to crypto support. The patch has been tested with 3.14.0-rc1
> > kernel.
> >
> > On a Haswell desktop, with turbo disabled and all cpus running
> > at maximum frequency, tcrypt shows AVX2 performance improvement
> > from 3% for 256 bytes update to 16% for 1024 bytes update over
> > AVX implementation.
> >
> > This patch adds sha1_avx2_transform(), the glue, build and
> > configuration changes needed for AVX2 optimization of
> > SHA1 transform to crypto support.
> >
> > sha1-ssse3 is one module which adds the necessary optimization
> > support (SSSE3/AVX/AVX2) for the low-level SHA1 transform function.
> > With better optimization support, transform function is overridden
> > as the case may be. In the case of AVX2, due to performance reasons
> > across datablock sizes, the AVX or AVX2 transform function is used
> > at run-time as it suits best. The Makefile change therefore appends
> > the necessary objects to the linkage. Due to this, the patch merely
> > appends AVX2 transform to the existing build mix and Kconfig support
> > and leaves the configuration build support as is.
> >
> > Signed-off-by: Chandramouli Narayanan <mouli@linux.intel.com>
>
> Very nice, good job. Thank you!
>
> Reviewed-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Marek Vasut
Thank you for reviewing the churn of patches!
Best regards,
- mouli
next prev parent reply other threads:[~2014-03-20 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 22:14 [PATCH v6 1/1] crypto: SHA1 transform x86_64 AVX2 chandramouli narayanan
2014-03-20 22:23 ` H. Peter Anvin
2014-03-21 0:09 ` Herbert Xu
2014-03-21 3:21 ` H. Peter Anvin
2014-03-20 22:24 ` Marek Vasut
2014-03-20 22:51 ` chandramouli narayanan [this message]
2014-03-21 14:41 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395355861.2367.57.camel@pegasus.jf.intel.com \
--to=mouli@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=ilya.albrekht@intel.com \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=marex@denx.de \
--cc=maxim.locktyukhin@intel.com \
--cc=ronen.zohar@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=wajdi.k.feghali@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox