From: Marek Vasut <marex@denx.de>
To: linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, "Marek Vasut" <marex@denx.de>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Dmitry Kasatkin" <dmitry.kasatkin@nokia.com>,
"Eric Bénard" <eric@eukrea.com>,
"Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>,
"Kent Yoder" <key@linux.vnet.ibm.com>,
"Michal Ludvig" <michal@logix.cz>,
"Varun Wadekar" <vwadekar@nvidia.com>,
"Vladimir Zapolskiy" <vladimir_zapolskiy@mentor.com>,
linux-geode@lists.infradead.org
Subject: [PATCH 3/4] crypto: geode: Consistently use AES_KEYSIZE_128
Date: Wed, 14 May 2014 11:36:40 +0200 [thread overview]
Message-ID: <1400060201-11519-3-git-send-email-marex@denx.de> (raw)
In-Reply-To: <1400060201-11519-1-git-send-email-marex@denx.de>
Consistently use AES_KEYSIZE_128 instead of arbitrary defined value.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Cc: Eric Bénard <eric@eukrea.com>
Cc: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: Kent Yoder <key@linux.vnet.ibm.com>
Cc: Michal Ludvig <michal@logix.cz>
Cc: Varun Wadekar <vwadekar@nvidia.com>
Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: linux-geode@lists.infradead.org
---
drivers/crypto/geode-aes.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
NOTE: Geode guys, can you please test this change ?
diff --git a/drivers/crypto/geode-aes.h b/drivers/crypto/geode-aes.h
index 73e7b5f..f442ca9 100644
--- a/drivers/crypto/geode-aes.h
+++ b/drivers/crypto/geode-aes.h
@@ -10,8 +10,6 @@
#define _GEODE_AES_H_
/* driver logic flags */
-#define AES_KEY_LENGTH 16
-
#define AES_MODE_ECB 0
#define AES_MODE_CBC 1
@@ -62,7 +60,7 @@ struct geode_aes_op {
u32 flags;
int len;
- u8 key[AES_KEY_LENGTH];
+ u8 key[AES_KEYSIZE_128];
u8 *iv;
union {
--
2.0.0.rc0
next prev parent reply other threads:[~2014-05-14 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 9:36 [PATCH 1/4] crypto: geode: Kill AES_MIN_BLOCK_SIZE Marek Vasut
2014-05-14 9:36 ` [PATCH 2/4] crypto: geode: Kill AES_IV_LENGTH Marek Vasut
2014-05-14 9:36 ` Marek Vasut [this message]
2014-05-14 9:36 ` [PATCH 4/4] crypto: geode: Weed out printk() from probe() Marek Vasut
2014-05-22 13:08 ` [PATCH 1/4] crypto: geode: Kill AES_MIN_BLOCK_SIZE Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400060201-11519-3-git-send-email-marex@denx.de \
--to=marex@denx.de \
--cc=benh@kernel.crashing.org \
--cc=dmitry.kasatkin@nokia.com \
--cc=eric@eukrea.com \
--cc=herbert@gondor.apana.org.au \
--cc=jussi.kivilinna@mbnet.fi \
--cc=key@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=michal@logix.cz \
--cc=vladimir_zapolskiy@mentor.com \
--cc=vwadekar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).