From: Paul Bolle <pebolle@tiscali.nl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ameen Ali <ameenali023@gmail.com>,
tim.c.chen@linux.intel.com, davem@davemloft.net,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] crypto/sha-mb/sha1_mb.c : Syntax error
Date: Mon, 16 Mar 2015 12:28:23 +0100 [thread overview]
Message-ID: <1426505303.26437.40.camel@x220> (raw)
In-Reply-To: <20150316105048.GD793@gondor.apana.org.au>
On Mon, 2015-03-16 at 21:50 +1100, Herbert Xu wrote:
> On Fri, Mar 13, 2015 at 11:38:21PM +0200, Ameen Ali wrote:
> > fixing a syntax-error .
> >
> > Signed-off-by : Ameen Ali <AmeenAli023@gmail.com>
>
> Applied.
The commit summary and the commit explanation are a bit misleading. This
is not a syntax error: it actually compiles just fine with GCC 4.8. (I
looked into that wondering whether this was stable material.) It's
telling that the commit explanation doesn't contain a copy of the error
message, which would have been very helpful if this really was a syntax
error.
The old code apparently works because the preprocessor converts
time_before() into time_after(). And the code generated for time_after()
will in its turn be wrapped in parentheses. That is, this generates
valid syntax by, well, accident. So this could as well be labeled a
style fix. A fix for a rather serious style defect, but still.
Paul Bolle
next prev parent reply other threads:[~2015-03-16 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 21:38 [PATCH 12/12] crypto/sha-mb/sha1_mb.c : Syntax error Ameen Ali
2015-03-16 10:50 ` Herbert Xu
2015-03-16 11:28 ` Paul Bolle [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-13 21:13 Ameen Ali
2015-03-13 21:33 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426505303.26437.40.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=ameenali023@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox