From: Tim Chen <tim.c.chen@linux.intel.com>
To: Stephan Mueller <smueller@chronox.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"H. Peter Anvin" <hpa@zytor.com>,
"David S.Miller" <davem@davemloft.net>,
Chandramouli Narayanan <mouli_7982@yahoo.com>,
Vinodh Gopal <vinodh.gopal@intel.com>,
James Guilford <james.guilford@intel.com>,
Wajdi Feghali <wajdi.k.feghali@intel.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code
Date: Thu, 29 Oct 2015 11:14:07 -0700 [thread overview]
Message-ID: <1446142447.14635.13.camel@schen9-desk2.jf.intel.com> (raw)
In-Reply-To: <1446135563.14635.11.camel@schen9-desk2.jf.intel.com>
On Thu, 2015-10-29 at 09:19 -0700, Tim Chen wrote:
> On Thu, 2015-10-29 at 03:03 +0100, Stephan Mueller wrote:
> > Am Mittwoch, 28. Oktober 2015, 14:19:29 schrieb Tim Chen:
> >
> > Hi Tim,
> >
> > >+
> > >+ /* check for dependent cpu features */
> > >+ if (!cpu_has_aes) {
> > >+ pr_err("aes_cbc_mb_mod_init: no aes support\n");
> > >+ err = -ENODEV;
> > >+ goto err1;
> > >+ }
> >
> > In your post 0/5, you say that this mechanism needs AVX2. In the existing
> > AESNI glue code I find
> >
> > #ifdef CONFIG_X86_64
> > #ifdef CONFIG_AS_AVX2
> > if (boot_cpu_has(X86_FEATURE_AVX2)) {
> >
> > ...
> >
> > Why would that CPU check not be needed here?
>
> Good catch. Will add check for avx2.
Actually since we are using only XMM registers and SSE instructions,
checking for SSE support will be sufficient.
Tim
prev parent reply other threads:[~2015-10-29 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1445565339.git.tim.c.chen@linux.intel.com>
2015-10-28 21:17 ` [PATCH 0/5] x86 AES-CBC encryption with AVX2 multi-buffer Tim Chen
2015-10-28 21:18 ` [PATCH 1/5] crypto: Multi-buffer encryptioin infrastructure support Tim Chen
2015-10-28 21:18 ` [PATCH 2/5] crypto: AES CBC multi-buffer data structures Tim Chen
2015-10-28 21:18 ` [PATCH 3/5] crypto: AES CBC multi-buffer scheduler Tim Chen
2015-10-28 21:19 ` [PATCH 4/5] crypto: AES CBC by8 encryption Tim Chen
2015-10-28 21:19 ` [PATCH 5/5] crypto: AES CBC multi-buffer glue code Tim Chen
2015-10-29 2:03 ` Stephan Mueller
2015-10-29 16:19 ` Tim Chen
2015-10-29 18:14 ` Tim Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446142447.14635.13.camel@schen9-desk2.jf.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=james.guilford@intel.com \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli_7982@yahoo.com \
--cc=smueller@chronox.de \
--cc=vinodh.gopal@intel.com \
--cc=wajdi.k.feghali@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox