From: Yang Pingchao <pingchao.yang@intel.com>
To: herbert@gondor.apana.org.au, dan.carpenter@oracle.com
Cc: tadeusz.struk@intel.com, linux-crypto@vger.kernel.org,
qat-linux@intel.com, kernel-janitors@vger.kernel.org,
Yang Pingchao <pingchao.yang@intel.com>
Subject: [PATCH] crypto: qat - fix some timeout tests
Date: Wed, 16 Dec 2015 14:09:50 +0800 [thread overview]
Message-ID: <1450246190-60770-1-git-send-email-pingchao.yang@intel.com> (raw)
Change the timeout condition since the times value would be -1 after
running MAX_RETRY_TIMES.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yang Pingchao <pingchao.yang@intel.com>
---
drivers/crypto/qat/qat_common/qat_hal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
index 81bd1fe..0ac0ba8 100644
--- a/drivers/crypto/qat/qat_common/qat_hal.c
+++ b/drivers/crypto/qat/qat_common/qat_hal.c
@@ -186,7 +186,7 @@ static int qat_hal_wait_cycles(struct icp_qat_fw_loader_handle *handle,
if (elapsed_cycles >= 8 && !(csr & (1 << ACS_ABO_BITPOS)))
return 0;
}
- if (!times) {
+ if (times < 0) {
pr_err("QAT: wait_num_cycles time out\n");
return -EFAULT;
}
--
2.6.4
next reply other threads:[~2015-12-16 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 6:09 Yang Pingchao [this message]
2015-12-22 13:23 ` [PATCH] crypto: qat - fix some timeout tests Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2015-12-15 10:05 [patch] " Dan Carpenter
2015-12-15 20:27 ` Tadeusz Struk
2015-12-15 23:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450246190-60770-1-git-send-email-pingchao.yang@intel.com \
--to=pingchao.yang@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).