Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: crypto: algif_aead - Switch to new AEAD interface
Date: Fri, 29 May 2015 23:32:09 +0200	[thread overview]
Message-ID: <1459394.UYHQzFnBPg@tachyon.chronox.de> (raw)
In-Reply-To: <4167986.EDUjNpGSba@tauon>

Am Freitag, 29. Mai 2015, 16:50:50 schrieb Stephan Mueller:

Hi Herbert,

> 
> Do we really need to copy in and copy out unneeded data? That sounds very
> inefficient. Besides, can't we leave it to user space to build the right
> memory structure? I.e. if user space wants in-place operation, it needs to
> ensure that the one buffer is sufficient for the requested operation (i.e.
> that the requirements for src lengths and dst lengths are covered).

Please disregard my comment for the memory structure -- using IOVECs, 
userspace is free to format the memory layout as necessary.

PS: I tested all code paths that I see for the new algif_aead and it works 
with the code currently in your tree. Please disregard the discussion around 
code changes.

-- 
Ciao
Stephan

      reply	other threads:[~2015-05-29 21:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27  9:24 crypto: algif_aead - Switch to new AEAD interface Herbert Xu
2015-05-27 10:10 ` Stephan Mueller
2015-05-27 10:14   ` Herbert Xu
2015-05-29 10:09 ` Stephan Mueller
2015-05-29 13:28   ` Herbert Xu
2015-05-29 14:50     ` Stephan Mueller
2015-05-29 21:32       ` Stephan Mueller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459394.UYHQzFnBPg@tachyon.chronox.de \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox