linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: vmx - comply with ABIs that specify vrsave as reserved.
@ 2016-04-29 14:03 Paulo Flabiano Smorigo
  2016-05-03  8:13 ` Herbert Xu
  0 siblings, 1 reply; 4+ messages in thread
From: Paulo Flabiano Smorigo @ 2016-04-29 14:03 UTC (permalink / raw)
  To: linux-kernel
  Cc: Paulo Flabiano Smorigo, Leonidas S. Barbosa, Herbert Xu,
	David S. Miller,
	open list:IBM Power VMX Cryptographic instructions

It gives significant improvements ( ~+15%) on some modes.

These code has been adopted from OpenSSL project in collaboration
with the original author (Andy Polyakov <appro@openssl.org>).
---
 drivers/crypto/vmx/ppc-xlate.pl | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/crypto/vmx/ppc-xlate.pl b/drivers/crypto/vmx/ppc-xlate.pl
index b999733..9f4994c 100644
--- a/drivers/crypto/vmx/ppc-xlate.pl
+++ b/drivers/crypto/vmx/ppc-xlate.pl
@@ -139,6 +139,26 @@ my $vmr = sub {
     "	vor	$vx,$vy,$vy";
 };
 
+# Some ABIs specify vrsave, special-purpose register #256, as reserved
+# for system use.
+my $no_vrsave = ($flavour =~ /aix|linux64le/);
+my $mtspr = sub {
+    my ($f,$idx,$ra) = @_;
+    if ($idx == 256 && $no_vrsave) {
+	"	or	$ra,$ra,$ra";
+    } else {
+	"	mtspr	$idx,$ra";
+    }
+};
+my $mfspr = sub {
+    my ($f,$rd,$idx) = @_;
+    if ($idx == 256 && $no_vrsave) {
+	"	li	$rd,-1";
+    } else {
+	"	mfspr	$rd,$idx";
+    }
+};
+
 # PowerISA 2.06 stuff
 sub vsxmem_op {
     my ($f, $vrt, $ra, $rb, $op) = @_;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: vmx - comply with ABIs that specify vrsave as reserved.
  2016-04-29 14:03 [PATCH] crypto: vmx - comply with ABIs that specify vrsave as reserved Paulo Flabiano Smorigo
@ 2016-05-03  8:13 ` Herbert Xu
  2016-05-05 14:09   ` Paulo Flabiano Smorigo
  0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2016-05-03  8:13 UTC (permalink / raw)
  To: Paulo Flabiano Smorigo
  Cc: linux-kernel, Leonidas S. Barbosa, David S. Miller,
	open list:IBM Power VMX Cryptographic instructions

On Fri, Apr 29, 2016 at 11:03:05AM -0300, Paulo Flabiano Smorigo wrote:
> It gives significant improvements ( ~+15%) on some modes.
> 
> These code has been adopted from OpenSSL project in collaboration
> with the original author (Andy Polyakov <appro@openssl.org>).

No sign-off.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] crypto: vmx - comply with ABIs that specify vrsave as reserved.
  2016-05-03  8:13 ` Herbert Xu
@ 2016-05-05 14:09   ` Paulo Flabiano Smorigo
  2016-05-10  9:53     ` Herbert Xu
  0 siblings, 1 reply; 4+ messages in thread
From: Paulo Flabiano Smorigo @ 2016-05-05 14:09 UTC (permalink / raw)
  To: linux-kernel
  Cc: Paulo Flabiano Smorigo, Leonidas S. Barbosa, Herbert Xu,
	David S. Miller,
	open list:IBM Power VMX Cryptographic instructions

It gives significant improvements ( ~+15%) on some modes.

These code has been adopted from OpenSSL project in collaboration
with the original author (Andy Polyakov <appro@openssl.org>).

Signed-off-by: Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>
---
 drivers/crypto/vmx/ppc-xlate.pl | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/crypto/vmx/ppc-xlate.pl b/drivers/crypto/vmx/ppc-xlate.pl
index b999733..9f4994c 100644
--- a/drivers/crypto/vmx/ppc-xlate.pl
+++ b/drivers/crypto/vmx/ppc-xlate.pl
@@ -139,6 +139,26 @@ my $vmr = sub {
     "	vor	$vx,$vy,$vy";
 };
 
+# Some ABIs specify vrsave, special-purpose register #256, as reserved
+# for system use.
+my $no_vrsave = ($flavour =~ /aix|linux64le/);
+my $mtspr = sub {
+    my ($f,$idx,$ra) = @_;
+    if ($idx == 256 && $no_vrsave) {
+	"	or	$ra,$ra,$ra";
+    } else {
+	"	mtspr	$idx,$ra";
+    }
+};
+my $mfspr = sub {
+    my ($f,$rd,$idx) = @_;
+    if ($idx == 256 && $no_vrsave) {
+	"	li	$rd,-1";
+    } else {
+	"	mfspr	$rd,$idx";
+    }
+};
+
 # PowerISA 2.06 stuff
 sub vsxmem_op {
     my ($f, $vrt, $ra, $rb, $op) = @_;
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: vmx - comply with ABIs that specify vrsave as reserved.
  2016-05-05 14:09   ` Paulo Flabiano Smorigo
@ 2016-05-10  9:53     ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2016-05-10  9:53 UTC (permalink / raw)
  To: Paulo Flabiano Smorigo
  Cc: linux-kernel, Leonidas S. Barbosa, David S. Miller,
	open list:IBM Power VMX Cryptographic instructions

On Thu, May 05, 2016 at 11:09:27AM -0300, Paulo Flabiano Smorigo wrote:
> It gives significant improvements ( ~+15%) on some modes.
> 
> These code has been adopted from OpenSSL project in collaboration
> with the original author (Andy Polyakov <appro@openssl.org>).
> 
> Signed-off-by: Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-05-10  9:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-29 14:03 [PATCH] crypto: vmx - comply with ABIs that specify vrsave as reserved Paulo Flabiano Smorigo
2016-05-03  8:13 ` Herbert Xu
2016-05-05 14:09   ` Paulo Flabiano Smorigo
2016-05-10  9:53     ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).