From: Stephan Mueller <smueller@chronox.de>
To: linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, aquini@redhat.com,
jeremy.wayne.powell@gmail.com, clemens@ladisch.de,
pwalten@au1.ibm.com, joe@perches.com
Subject: Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator
Date: Wed, 21 May 2014 22:17:30 +0200 [thread overview]
Message-ID: <1463834.NEeonhXFuP@myon.chronox.de> (raw)
In-Reply-To: <4917794.FPSphFc8Fa@myon.chronox.de>
Am Mittwoch, 21. Mai 2014, 06:18:58 schrieb Stephan Mueller:
Hi,
> +/*
> + * Tests as defined in 11.3.2 in addition to the cipher tests: testing
> + * of the error handling.
> + *
> + * Note: testing of failing seed source as defined in 11.3.2 is not
> applicable + * as seed source of get_random_bytes does not fail.
> + *
> + * Note 2: There is no sensible way of testing the reseed counter
> + * enforcement, so skip it.
> + */
> +static inline int __init drbg_healthcheck_sanity(void)
> +{
> +#ifdef CONFIG_CRYPTO_FIPS
> + unsigned int len = 0;
This variable must be signed int as otherwise the BUG_ON checks will always
fail. This error is a leftover from the return code change of drbg_generate().
It will be fixed in the next release.
Ciao
Stephan
--
| Cui bono? |
next prev parent reply other threads:[~2014-05-21 20:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 4:18 [PATCH v7 0/6] SP800-90A Deterministic Random Bit Generator Stephan Mueller
2014-05-21 4:18 ` [PATCH v7 1/6] " Stephan Mueller
2014-05-21 20:17 ` Stephan Mueller [this message]
2014-05-23 21:10 ` Herbert Xu
2014-05-26 5:44 ` Stephan Mueller
2014-05-21 4:19 ` [PATCH v7 2/6] header file for DRBG Stephan Mueller
2014-05-21 4:20 ` [PATCH v7 3/6] DRBG kernel configuration options Stephan Mueller
2014-05-21 4:21 ` [PATCH v7 4/6] compile the DRBG code Stephan Mueller
2014-05-21 4:21 ` [PATCH v7 5/6] DRBG testmgr test vectors Stephan Mueller
2014-05-21 4:22 ` [PATCH v7 6/6] Add DRBG test code to testmgr Stephan Mueller
2014-05-23 21:14 ` [PATCH v7 0/6] SP800-90A Deterministic Random Bit Generator Herbert Xu
2014-05-26 5:42 ` Stephan Mueller
2014-05-30 9:05 ` Herbert Xu
2014-05-30 10:08 ` Stephan Mueller
2014-05-30 10:52 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463834.NEeonhXFuP@myon.chronox.de \
--to=smueller@chronox.de \
--cc=aquini@redhat.com \
--cc=clemens@ladisch.de \
--cc=jeremy.wayne.powell@gmail.com \
--cc=joe@perches.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pwalten@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).