From: Will Thomas <will.thomas@imgtec.com>
To: <linux-crypto@vger.kernel.org>
Cc: Will Thomas <will.thomas@imgtec.com>
Subject: [PATCH 2/6] crypto: img-hash - Fix hash request context
Date: Mon, 11 Jul 2016 10:33:32 +0100 [thread overview]
Message-ID: <1468229616-3888-3-git-send-email-will.thomas@imgtec.com> (raw)
In-Reply-To: <1468229616-3888-1-git-send-email-will.thomas@imgtec.com>
Move 0 length buffer to end of structure to stop overwriting
fallback request data. This doesn't cause a bug itself as the
buffer is never used alongside the fallback but should be
changed.
Signed-off-by: Will Thomas <will.thomas@imgtec.com>
Reviewed-by: James Hartley <james.hartley@imgtec.com>
---
drivers/crypto/img-hash.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index a5f270b..7fa6aa4 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -102,8 +102,10 @@ struct img_hash_request_ctx {
unsigned long op;
size_t bufcnt;
- u8 buffer[0] __aligned(sizeof(u32));
struct ahash_request fallback_req;
+
+ /* Zero length buffer must remain last member of struct */
+ u8 buffer[0] __aligned(sizeof(u32));
};
struct img_hash_ctx {
--
2.1.4
next prev parent reply other threads:[~2016-07-11 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 9:33 [PATCH 0/6] crypto: img-hash - fixes and interface changes Will Thomas
2016-07-11 9:33 ` [PATCH 1/6] crypto: img-hash - Fix null pointer exception Will Thomas
2016-07-12 7:41 ` Herbert Xu
2016-07-11 9:33 ` Will Thomas [this message]
2016-07-12 7:43 ` [PATCH 2/6] crypto: img-hash - Fix hash request context Herbert Xu
2016-07-13 14:45 ` Will Thomas
2016-07-11 9:33 ` [PATCH 3/6] crypto: img-hash - Reconfigure DMA Burst length Will Thomas
2016-07-11 9:33 ` [PATCH 4/6] crypto: img-hash - Add suspend resume hooks for img hash Will Thomas
2016-07-11 9:33 ` [PATCH 5/6] crypto: img-hash - Add support for export and import Will Thomas
2016-07-12 7:49 ` Herbert Xu
2016-07-13 14:01 ` Will Thomas
2016-07-18 6:13 ` Herbert Xu
2016-07-11 9:33 ` [PATCH 6/6] crypto: img-hash - log a successful probe Will Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468229616-3888-3-git-send-email-will.thomas@imgtec.com \
--to=will.thomas@imgtec.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).